-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2909: Fix copy text being cut off in the suggest your region page #3033
2909: Fix copy text being cut off in the suggest your region page #3033
Conversation
704d7e0
to
65c191d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo, welcome back! 🥳 🥳 🥳
This does the job but I think there are easier ways to do it, especially since the text in the template is always German, and so the length shouldn't change too much (though we do still have different device sizes to take into account). For example, I was able to get the entire text to show up just by increasing the margin-bottom
in the TemplateText
.
65c191d
to
310d60e
Compare
yes, you are totally right. I think I oversaw the changes when I was trying it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Tested on an emulated iPhone 16 and an emulated iPad Air 13-inch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested (emulation) on Pixel 2: 5.0″ screen and Pixel 7 Pro: 6.71″ screen
Works great!👍️
310d60e
to
13c55b5
Compare
Short description
Currently the copy text is not shown fully, half of it is cut off. The text should be fully shown.
Proposed changes
Fix the scroll view and the template text's style
Side effects
none
Resolved issues
Fixes: #2909