Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2909: Fix copy text being cut off in the suggest your region page #3033

Merged
merged 1 commit into from
Jan 11, 2025

Conversation

lunars97
Copy link
Contributor

@lunars97 lunars97 commented Jan 9, 2025

Short description

Currently the copy text is not shown fully, half of it is cut off. The text should be fully shown.

Proposed changes

Fix the scroll view and the template text's style

Side effects

none

Resolved issues

Fixes: #2909


@lunars97 lunars97 changed the title Fix copy text being cut off in the suggest your region page 2909: Fix copy text being cut off in the suggest your region page Jan 9, 2025
@lunars97 lunars97 force-pushed the 2909-copy-text-is-cut-off-on-suggest-your-region branch 2 times, most recently from 704d7e0 to 65c191d Compare January 9, 2025 12:13
Copy link
Contributor

@LeandraH LeandraH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo, welcome back! 🥳 🥳 🥳

This does the job but I think there are easier ways to do it, especially since the text in the template is always German, and so the length shouldn't change too much (though we do still have different device sizes to take into account). For example, I was able to get the entire text to show up just by increasing the margin-bottom in the TemplateText.

@lunars97 lunars97 force-pushed the 2909-copy-text-is-cut-off-on-suggest-your-region branch from 65c191d to 310d60e Compare January 10, 2025 09:42
@lunars97
Copy link
Contributor Author

Woohoo, welcome back! 🥳 🥳 🥳

This does the job but I think there are easier ways to do it, especially since the text in the template is always German, and so the length shouldn't change too much (though we do still have different device sizes to take into account). For example, I was able to get the entire text to show up just by increasing the margin-bottom in the TemplateText.

yes, you are totally right. I think I oversaw the changes when I was trying it :)

Copy link
Contributor

@LeandraH LeandraH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! Tested on an emulated iPhone 16 and an emulated iPad Air 13-inch.

native/src/routes/CityNotCooperating.tsx Show resolved Hide resolved
Copy link
Contributor

@bahaaTuffaha bahaaTuffaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested (emulation) on Pixel 2: 5.0″ screen and Pixel 7 Pro: 6.71″ screen
Works great!👍️

@lunars97 lunars97 force-pushed the 2909-copy-text-is-cut-off-on-suggest-your-region branch from 310d60e to 13c55b5 Compare January 10, 2025 22:36
@lunars97 lunars97 merged commit 198278b into main Jan 11, 2025
9 checks passed
@lunars97 lunars97 deleted the 2909-copy-text-is-cut-off-on-suggest-your-region branch January 11, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommend integreat text cut off
3 participants