2548: Split up web feedback at the first level into two smileys again #3004
Conversation
LeandraH
requested review from
steffenkleinle,
ztefanie and
f1sh1918
as code owners
|
|
|
Oooooh, good catch, thanks! |
| <ToolbarItem | ||
| icon={HappySmileyIcon} | ||
| text={t('useful')} | ||
| onClick={() => { | ||
| setIsFeedbackOpen(true) | ||
| setIsPositiveRating(true) | ||
| }} | ||
| /> | ||
| <ToolbarItem | ||
| icon={SadSmileyIcon} | ||
| text={t('notUseful')} | ||
| onClick={() => { | ||
| setIsFeedbackOpen(true) | ||
| setIsPositiveRating(false) | ||
| }} | ||
| /> |
There was a problem hiding this comment.
❓ Wouldn't it make more sense to just render the FeedbackToolbarItem twice? I think this way its pretty confusing that one feedback toolbar item renders two toolbar items. That way, there would also be no need to raise the ispositiveRating state to this compoennt
There was a problem hiding this comment.
Hmm, interesting idea, I guess we could do that? Or at least rename the component. I guess I'll open another PR for that 😅
There was a problem hiding this comment.
Sorry, I didn't get that the PR is already merged. If you feel motivated, otherwise this is alright as well.
There was a problem hiding this comment.
All good, you're right, it's a good idea :)
Short description
The municipalities have been receiving way less feedback since we made some changes there about half a year ago. In this PR, I changed the sidebar in web desktop / the footer in web mobile to show the two smileys instead of the button saying Feedback.
Proposed changes
Side effects
Testing
Resolved issues
Fixes: #2548