Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2945: Distinguish automatic and counselor messages #2963

Merged
merged 6 commits into from
Nov 4, 2024

Conversation

ztefanie
Copy link
Member

Short description

Added different icons. I tried different styles, check here if you prefer an other option:
image

The backend endpoint always returns false for "automatic_answer". I asked the backend team about this.

Testing

Open the chat. Change the conditional in ChatMessage.tsx getIcon function to return other icon to see it.

Not ready to merge, because backend endpoint is not working properly. Please add your thoughts on the icons.

Fixes: #2945


Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on firefox, works as expected 🎉 Thanks for taking care of this 💛

assets/icons/chatbot-bot.svg Outdated Show resolved Hide resolved
assets/icons/chatbot-person.svg Outdated Show resolved Hide resolved
assets/icons/chatbot-person.svg Outdated Show resolved Hide resolved
web/src/components/ChatMessage.tsx Outdated Show resolved Hide resolved
web/src/components/ChatMessage.tsx Outdated Show resolved Hide resolved
@steffenkleinle
Copy link
Member

Added different icons. I tried different styles, check here if you prefer an other option

I mean thats what the issue was for and probably best to ask UI/UX for this. Ping @nikolahoff, have a look at the currently used icons here: https://github.com/digitalfabrik/integreat-app/pull/2963/files

Copy link
Contributor

@LeandraH LeandraH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! Not tested

Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, thank you. It just seems like the response from the CMS is now wrong, I am getting automatic_answer: false for a clearly automatic answer...

@@ -10,6 +10,7 @@ const StyledIcon = styled(SVG)<{ $directionDependent: boolean; $reverse: boolean
color: ${props => props.theme.colors.textColor};
width: 24px;
height: 24px;
--theme-color: ${props => props.theme.colors.themeColor};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, TIL 🤯

@ztefanie
Copy link
Member Author

ztefanie commented Nov 4, 2024

Currently blocked due to backend bug: https://chat.tuerantuer.org/digitalfabrik/pl/h51bd7zb5tfc5cye7q8ngghcey

@ztefanie
Copy link
Member Author

ztefanie commented Nov 4, 2024

ok the backend bug is only on Testumgebung, so this could be merged:

AFAICT there is nothing blocking right now.
The automatic_answer is available in all relevant API versions. For testumgebung it returns the false value in all(?) cases. I expect that this is related to the Zammad Config. For muenchen on webnext it returns also true where it is expected.

@ztefanie ztefanie force-pushed the 2945-distinguish-automatic-and-counselor-messages branch from fcccfd1 to ff3299c Compare November 4, 2024 08:45
@ztefanie ztefanie merged commit cb12884 into main Nov 4, 2024
9 checks passed
@ztefanie ztefanie deleted the 2945-distinguish-automatic-and-counselor-messages branch November 4, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Chat] Distinguish automatic messages and counselor messages
3 participants