-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2945: Distinguish automatic and counselor messages #2963
2945: Distinguish automatic and counselor messages #2963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on firefox, works as expected 🎉 Thanks for taking care of this 💛
I mean thats what the issue was for and probably best to ask UI/UX for this. Ping @nikolahoff, have a look at the currently used icons here: https://github.com/digitalfabrik/integreat-app/pull/2963/files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you! Not tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, thank you. It just seems like the response from the CMS is now wrong, I am getting automatic_answer: false
for a clearly automatic answer...
@@ -10,6 +10,7 @@ const StyledIcon = styled(SVG)<{ $directionDependent: boolean; $reverse: boolean | |||
color: ${props => props.theme.colors.textColor}; | |||
width: 24px; | |||
height: 24px; | |||
--theme-color: ${props => props.theme.colors.themeColor}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, TIL 🤯
Currently blocked due to backend bug: https://chat.tuerantuer.org/digitalfabrik/pl/h51bd7zb5tfc5cye7q8ngghcey |
ok the backend bug is only on Testumgebung, so this could be merged:
|
fcccfd1
to
ff3299c
Compare
Short description
Added different icons. I tried different styles, check here if you prefer an other option:
The backend endpoint always returns false for "automatic_answer". I asked the backend team about this.
Testing
Open the chat. Change the conditional in ChatMessage.tsx getIcon function to return other icon to see it.
Not ready to merge, because backend endpoint is not working properly. Please add your thoughts on the icons.
Fixes: #2945