2808: Add a filter by date option to events #2898

bahaaTuffaha · 2024-08-27T10:34:07Z

Short description

Filtering events by date

Proposed changes

For web:

Created a component called CustomDatePicker and used Input type='date' as date picker.

For native:

Created a component called CustomDatePicker used react-native TextInput and IconButton to show calendar modal.
Another component I added is for Calender Range picker called CalendarRangeModal I used react-native-calendars library and tried to mimic the styling like the design in figma.

Shared:

Created a hook called useDateFilter that accepts events then will validate and returns filteredEvents.

Side effects

None.

Resolved issues

Fixes: #2808

…ts by from and to date

… the date filter

…hanging color when opening calendar

…lendarRangeModal + CustomDatePicker for native

…ter hook

…option-to-events

…dars)

…option-to-events

steffenkleinle

Hey, thank you for your PR, looks pretty nice already! Nice work 🎉

I just reviewed and tested native so far and everything works and looks as expected. I will review web once the comments have been addressed (I think the PR is quite huge, perhaps it would be better to merge it one by one and split up the PR, if possible).

I have a few remarks regarding coding style and complexity. If you feel like I misunderstood something or your solution makes more sense, please tell.

General changes that would be a good addition:

Use DateTime to avoid manual parsing and formatting as well as validating
Clicking next to the date picker could/should close it for better UX
If you delete a slash in the date picker, you can't readd it (since the keyboard only shows numbers). A better choice would perhaps be to implement fields for day, month, and year separately, so you can only edit either one at a time. Not sure if this is an optimal solution though, so if you have any other ideas let me know.

Keep in mind that I did not mention every occurrence of things that could be improved, please apply the suggestions to other parts in the code, too.

web/tsconfig.json

assets/icons/calendar-events.svg

assets/icons/expand.svg

assets/icons/shrink.svg

native/src/components/CalendarRangeModal.tsx

translations/translations.json

release-notes/unreleased/2808-Add-a-filter-by-date-option-to-events.yml

native/src/utils/calendarRangeUtils.ts

shared/hooks/useDateFilter.ts

native/src/components/CalendarRangeModal.tsx

shared/hooks/useDateFilter.ts

translations/translations.json

web/src/components/FilterToggle.tsx

…option-to-events

native/src/components/DatePicker.tsx

native/src/components/EventsDateFilter.tsx

web/src/components/DatePicker.tsx

web/src/components/EventsDateFilter.tsx

steffenkleinle · 2024-09-12T06:28:40Z

Some thoughts on the behavior:

My personal opinion is that if I never selected a time period, no filtering should be done and all events should be shown. Only if I manually set a start and end date, I want the events to be filtered.
Usually, confirming actions, i.e. ok in this case, are placed on the right side while `cancel´ should be placed on the left side of the screen (at least for LTR languages): https://m2.material.io/components/dialogs#actions. This is also the case in the designs.
If an invalid date range is selected with the date picker (i.e. no start date, no end date, end date before start date) it should not be possible to press ok (as nothing will happen anyway and the user will be confused about that). Instead the button should be disabled, greyed out.
If a date is selected that is before the current fromDate (and if set, the toDate), it should be set as new fromDate and toDate should be cleared. Currently, if only a fromDate is selected, the following happens (see screenshot)

One more general question:
Is there any reason you chose the names fromDate and toDate over e.g. startDate and endDate?

shared/hooks/useDateFilter.ts

steffenkleinle · 2024-09-12T07:07:07Z

Sadly I just realized we have another problem. A lot of our events are recurring, i.e. happening multiple times, for example every week. Our filtering should reflect that and include events that have recurrences in the selected time period. This might not be that easy, so perhaps we should do that in a separate PR. Has to be done before this is good to go though sadly :/

bahaaTuffaha · 2024-09-12T13:40:56Z

Sadly I just realized we have another problem. A lot of our events are recurring, i.e. happening multiple times, for example every week. Our filtering should reflect that and include events that have recurrences in the selected time period. This might not be that easy, so perhaps we should do that in a separate PR. Has to be done before this is good to go though sadly :/

I think it can be done by modifying the filter maybe using rrule.between() event.date has recurrenceRule type RRuleType | null

…tByPlaceholderText

…option-to-events

steffenkleinle

Thanks for the changes and trying to make it work with our recurring events. I still see two problems though (which were also the reasons why I said I'd rather do this in a separate PR):

if the filters are set, only recurrences that are within that time period should be shown
this only works if one of the first MAX_DATE_RECURRENCES is in the selected time period. If it is a later recurrence, this won't work. You'd therefore need to adjust the recurrences function to accept start/end date values

Furthermore, there are some warnings regarding code complexity still, please try to adjust your code to address those.

shared/hooks/useDateFilter.ts

… for Code-Climate

…option-to-events

steffenkleinle

The app still shows the "wrong" recurrences if a filter is set.
In this case, the next date shown should be the 23rd.
I think you just have to pass the current filter values there as well.

Great solution for the recurrences though, this was way simpler than I thought. Nice 🎉 🚀
Nearly there :)

shared/api/models/DateModel.ts

shared/hooks/useDateFilter.ts

web/src/routes/EventsPage.tsx

shared/utils/dateFilterUtils.ts

steffenkleinle

Amazing, great work! Thank you so much for all the work 🎉

…option-to-events

codeclimate · 2024-10-16T12:14:20Z

Code Climate has analyzed commit ab81a63 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	4

The test coverage on the diff in this pull request is 58.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.8%.

View more on Code Climate.

ztefanie

I am not really happy with this solution, because:

When a user only wants to specify a end date, and clicks on the calendar of the "to" input field, a "from" date is selected nevertheless. This is not how this should work intuitively.
When selecting a "from" date from the date picker and entering the "to" date with a text input, it will not work.
When selecting a "from" date for the date picker, i cannot click "ok" in the calendar and if i close the calendar the date is not in the input field.
When using the input field, the and entering the date by keyboard, when i entered two digits for "dd" it should automatically go to the "mm" input, as on a smartphone it is quite annoying to click on the next section, which is very small.

As the library you use, does not really fit our needs of selecting a range, is there any reason to not use e.g. this library? https://www.npmjs.com/package/react-native-ui-datepicker

native/src/routes/Events.tsx

ztefanie · 2024-10-21T07:20:33Z

native/src/components/DatePicker.tsx

+const DatePicker = ({ title, date, setDate, error, modalOpen, setModalOpen }: DatePickerProps): ReactElement => {
+  const [inputDay, setInputDay] = useState(date?.toFormat('dd'))
+  const [inputMonth, setInputMonth] = useState(date?.toFormat('MM'))
+  const [inputYear, setInputYear] = useState(date?.toFormat('yyyy'))


I think it is not very good, to have separate state for day, month and year. This leads to

unnecessary re-renders

allows invalid dates to be entered, like 31.02.2024

I think it is not very good, to have separate state for day, month and year. This leads to

1. unnecessary re-renders

Tbh I don't think there is a difference between separate states or single state for the date here. If one value is changed, there is a rerender. It does not matter if we change a single state multiple times or a multi state multiple times.

2. allows invalid dates to be entered, like 31.02.2024

It is never completely preventable that no invalid date is entered, for example by copy and paste. If it is correctly handled/validated, I don't see a reason why that has to be a problem.

native/src/components/CalendarRangeModal.tsx

steffenkleinle · 2024-10-21T08:06:29Z

I am not really happy with this solution, because:

1. When a user only wants to specify a end date, and clicks on the calendar of the "to" input field, a "from" date is selected nevertheless. This is not how this should work intuitively.

2. When selecting a "from" date from the date picker and entering the "to" date with a text input, it will not work.

3. When selecting a "from" date for the date picker, i cannot click "ok" in the calendar and if i close the calendar the date is not in the input field.

4. When using the input field, the and entering the date by keyboard, when i entered two digits for "dd" it should automatically go to the "mm" input, as on a smartphone it is quite annoying to click on the next section, which is very small.

As the library you use, does not really fit our needs of selecting a range, is there any reason to not use e.g. this library? https://www.npmjs.com/package/react-native-ui-datepicker

Good find, I think these things should be addressed. I think this is only the case for native, right? I think you should be able to just adjust the day marking handling and some other logic though, I am pretty sure there is no need to switch the library because of this.

ztefanie · 2024-10-21T08:33:58Z

I am not really happy with this solution, because:
1. When a user only wants to specify a end date, and clicks on the calendar of the "to" input field, a "from" date is selected nevertheless. This is not how this should work intuitively.

2. When selecting a "from" date from the date picker and entering the "to" date with a text input, it will not work.

3. When selecting a "from" date for the date picker, i cannot click "ok" in the calendar and if i close the calendar the date is not in the input field.

4. When using the input field, the and entering the date by keyboard, when i entered two digits for "dd" it should automatically go to the "mm" input, as on a smartphone it is quite annoying to click on the next section, which is very small.
As the library you use, does not really fit our needs of selecting a range, is there any reason to not use e.g. this library? https://www.npmjs.com/package/react-native-ui-datepicker
Good find, I think these things should be addressed. I think this is only the case for native, right? I think you should be able to just adjust the day marking handling and some other logic though, I am pretty sure there is no need to switch the library because of this.

Why use a library that does not fit our needs, if there are libraries that we can just use out of the box?

steffenkleinle · 2024-10-21T15:20:45Z

I am not really happy with this solution, because:
1. When a user only wants to specify a end date, and clicks on the calendar of the "to" input field, a "from" date is selected nevertheless. This is not how this should work intuitively.

2. When selecting a "from" date from the date picker and entering the "to" date with a text input, it will not work.

3. When selecting a "from" date for the date picker, i cannot click "ok" in the calendar and if i close the calendar the date is not in the input field.

4. When using the input field, the and entering the date by keyboard, when i entered two digits for "dd" it should automatically go to the "mm" input, as on a smartphone it is quite annoying to click on the next section, which is very small.
As the library you use, does not really fit our needs of selecting a range, is there any reason to not use e.g. this library? https://www.npmjs.com/package/react-native-ui-datepicker
Good find, I think these things should be addressed. I think this is only the case for native, right? I think you should be able to just adjust the day marking handling and some other logic though, I am pretty sure there is no need to switch the library because of this.
Why use a library that does not fit our needs, if there are libraries that we can just use out of the box?

Why do you think that this library does not fit our need? I think it does pretty much exactly what we need it to do, i.e. being able to select and mark dates. We just have to slightly adjust how when we set start and end dates 🤔

bahaaTuffaha · 2024-10-21T16:13:45Z

I am not really happy with this solution, because:

When a user only wants to specify a end date, and clicks on the calendar of the "to" input field, a "from" date is selected nevertheless. This is not how this should work intuitively.

When selecting a "from" date from the date picker and entering the "to" date with a text input, it will not work.

When selecting a "from" date for the date picker, i cannot click "ok" in the calendar and if i close the calendar the date is not in the input field.

When using the input field, the and entering the date by keyboard, when i entered two digits for "dd" it should automatically go to the "mm" input, as on a smartphone it is quite annoying to click on the next section, which is very small.

As the library you use, does not really fit our needs of selecting a range, is there any reason to not use e.g. this library? https://www.npmjs.com/package/react-native-ui-datepicker

I actually tried to use this library but it has issues with RTL languages the will get switched up like this and we tried to solve it and non worked ...
look at this : 4df2415

ztefanie · 2024-10-24T11:23:47Z

I will dismiss my review as "changes requested" here, as I am on vacation and do not want to block this.

@bahaaTuffaha Thanks for explaining why the other library was not an option and good work in general with this PR, the UI looks pretty nice and looking forward to have this feature in Integreat 🚀

Do not want to block this during my vacation

LeandraH

Very nice, thank you for all your work on this already!

I only managed to do a somewhat superficial review, and only of the native parts, but I have found a few more things that could do some work.

There seems to be a fade-in animation when showing the filters but not when hiding the filters.

I put in the dates 1.10.2024 - 24.10.2024 and got dates from 25.10.2024 - 6.11.2024

Edit: I have since realized that those are recurring events. That's cool but we need to show them with the dates that are during the selected period.

I find the interactions in the CalendarRangeModal confusing. My expectations from the way other date pickers work would be that the calendar closes when I chose an end date. There are a few other behaviors that I don't expect but I think they would all be covered by closing the calendar when the second date is selected.
I get the following warning in my console: WARN (ADVICE) "fit-content" is not a valid dimension. Dimensions must be a number, "auto", or a string suffixed with "%".
The inputs for with 'dd', 'mm' and 'yyyy' do absolutely nothing when I tap on them in emulated iOS, don't even give me an error message.
If I enter e.g. 01.11.2024 into the start date, then tap somewhere else, then try to edit the day of the start date again, nothing I type is accepted until I first delete the number that is in there already.

I would suggest maybe taking an hour or two and looking at this with fresh eyes and trying to do your own code review. I find it often helps me to improve my own code when I have to understand it after not having looked at it in a while.

LeandraH · 2024-10-25T10:37:07Z

native/src/components/CalendarRangeModal.tsx

+  justify-content: ${props => (props.theme.contentDirection === 'rtl' ? 'flex-start' : 'flex-end')};
+  flex-direction: ${props => (props.theme.contentDirection === 'rtl' ? 'row-reverse' : 'row')};


❓ This does seem odd, I would expect the combination of these two lines to do nothing since the positioning is turned around twice?

native/src/components/CalendarRangeModal.tsx

native/src/components/DatePicker.tsx

LeandraH · 2024-10-25T12:55:18Z

native/src/components/DatePicker.tsx

+            value={inputDay}
+          />
+          <Text>.</Text>
+          <Input


🔧 I think the inputs could be pulled into a separate component to improve legibility.

I still think that the inputs could be pulled into a separate component to improve legibility. :)

native/src/components/DatePicker.tsx

LeandraH · 2024-10-25T13:05:06Z

native/src/components/__tests__/DatePicker.spec.tsx

🔧 Thank you for always writing tests immediately! I think this is a good place to expand on some tests :)

I added 3 more but I couldn't get the .focus() or fireEvent.focus() working to test backspace jumping or even jumping forward from day to the month when its entered.

LeandraH · 2024-10-30T15:27:15Z

I just had a short call with Svenja to show her the current state and she suggested also zero-padding the dates here:

LeandraH · 2024-10-30T15:36:41Z

When this is merged, we should make a note in this thread that it will be deployed to production the Monday after the next

…g validation

…option-to-events

…ndividually

…st for iOS

LeandraH

Nice work, we're getting there! I have a few more general comments:

As you already noticed, you haven't dealt with the animation yet, and I think it would also be nice to have one in the web.
While I agree that we should show recurring events in the filtered list, we definitely need to show them with the date that is within that time frame, or show in some other way why these events are shown even though the filter should be hiding them.
In native, I still find the interactions in the CalendarRangeModal confusing. My expectations from the way other date pickers work would be that the calendar closes when I chose an end date. There are a few other behaviors that I don't expect but I think they would all be covered by closing the calendar when the second date is selected.
I like your solution for dealing with someone opening an input field a second time, very nice! But I think we still need a better solution for people putting in invalid formats. I think we should let them enter what they want and validate on blur. I would expect a number that is too high to be turned into the maximum possible number, and otherwise invalid dates to either be blanked or get a red outline and an explaining text. I guess an error would be ideal but it’s also more work to add an error behavior for something that, realistically speaking, won’t be happening all that much.

LeandraH · 2024-11-05T12:20:32Z

native/src/components/CalendarRangeModal.tsx

+  padding: 5px 14px;
+`
+
+const OPACITY_DISABLED = 0.5


🙃 OPACITY_DISABLED sounds to me like it should be a boolean of whether the opacity is disabled. Since this is supposed to be the opacity of a disabled button, I would say it should be called DISABLED_OPACITY.

LeandraH · 2024-11-05T13:14:13Z

native/src/components/CalendarRangeModal.tsx

+
+  const textButtonStyles = {
+    container: {
+      height: 40,


❌ The height can go directly into the StyledTextButton

LeandraH · 2024-11-05T13:20:02Z

native/src/components/CalendarRangeModal.tsx

+              if (tempStartDate && currentInput === 'from' && tempEndDate == null) {
+                setStartDate(tempStartDate)
+              } else if (tempStartDate && currentInput === 'to' && tempEndDate == null) {
+                setEndDate(tempStartDate)
+              } else if (tempStartDate && tempEndDate) {
+                setStartDate(tempStartDate)
+                setEndDate(tempEndDate)
+              }
+              setTempStartDate(null)
+              setTempEndDate(null)
+              closeModal()


🔧 I think this entire block could do with being pulled into a well-named function. Maybe also refactor it a little bit while you're at it, first thing I see: the lines 122 and 124 are almost the same, you could have

one if statement with the shared parts and

in the then part a ternary operator to decide which date should be set.

LeandraH · 2024-11-05T13:21:19Z

native/src/components/CalendarRangeModal.tsx

+            type='clear'
+            disabled={
+              (tempStartDate === null && tempEndDate === null) ||
+              Boolean(tempStartDate && tempEndDate && tempStartDate > tempEndDate)


🙃 We usually use !! to type cast something into a boolean :)

LeandraH · 2024-11-05T13:23:05Z

native/src/components/CalendarRangeModal.tsx

+              setTempStartDate(startDate)
+              setTempEndDate(endDate)


❓ Why are you setting these temporary values as you're closing the modal? Wouldn't they be filled in correctly anyway with the next opening?

LeandraH · 2024-11-05T16:47:45Z

web/src/components/EventsDateFilter.tsx

+
+const DateSection = styled.div`
+  display: flex;
+  flex-direction: row;


🔧 That's the default direction, we don't need it

LeandraH · 2024-11-05T16:47:54Z

web/src/components/EventsDateFilter.tsx

+
+const StyledButton = styled(Button)`
+  display: flex;
+  flex-direction: row;


🔧 Same here

LeandraH · 2024-11-05T16:48:49Z

web/src/components/EventsDateFilter.tsx

+
+const ResetFilterText = ({ startDate, endDate }: ResetFilterTextProps) => {
+  const { t } = useTranslation('events')
+  const title = `${t('resetFilter')} ${startDate?.toLocal().toFormat('dd.MM.yyyy') ?? '∞'} - ${endDate?.toLocal().toFormat('dd.MM.yyyy') ?? '∞'}`


Suggested change

const title = `${t('resetFilter')} ${startDate?.toLocal().toFormat('dd.MM.yyyy') ?? '∞'} - ${endDate?.toLocal().toFormat('dd.MM.yyyy') ?? '∞'}`

const title = `${t('resetFilter')} ${startDate?.toLocaleString({ day: '2-digit', month: '2-digit', year: 'numeric' } ?? '∞'} - ${endDate?.toLocaleString({ day: '2-digit', month: '2-digit', year: 'numeric' } ?? '∞'}`

Actually, that's not a title, that's a text :)

LeandraH · 2024-11-05T16:51:07Z

web/src/components/FilterToggle.tsx

+
+const StyledButton = styled(Button)`
+  display: flex;
+  flex-direction: row;


Also unnecessary :)

LeandraH · 2024-11-05T16:51:43Z

web/src/components/FilterToggle.tsx

+  toggle,
+  setToggleDateFilter,
+}: {
+  toggle: boolean


🙃 As discussed in the native part, I find this naming confusing

bahaaTuffaha added 14 commits August 20, 2024 20:24

2808: Creating a component called CustomDatePicker and filtering even…

5028027

…ts by from and to date

2808: Creating a hook for useDateFilter and a toggle to hide and show…

b6683da

… the date filter

2808: web changes and adding translation and direction for RTL plus c…

8dd13b4

…hanging color when opening calendar

2828: added a library called react-native-ui-datepicker and create Ca…

3fb9deb

…lendarRangeModal + CustomDatePicker for native

2808: Added DateFilterToggle to native and improvements to useDateFil…

566da43

…ter hook

2808: Adding translations and using React-native modal

3c0dbe5

Merge remote-tracking branch 'origin' into 2808-Add-a-filter-by-date-…

63d158a

…option-to-events

2808: Replacing (react-native-ui-datepicker) with (react-native-calen…

4df2415

…dars)

Added some tests and release note

c67fd25

Merge remote-tracking branch 'origin' into 2808-Add-a-filter-by-date-…

60f9de7

…option-to-events

2808: Refactoring code + some improvements

193909c

Merge remote-tracking branch 'origin' into 2808-Add-a-filter-by-date-…

e701023

…option-to-events

2808: prettier:check fixed for tsconfig

5d18825

2808: Fixing Typescript issues

c1cab6d

steffenkleinle requested changes Aug 28, 2024

View reviewed changes

bahaaTuffaha and others added 2 commits August 29, 2024 18:13

2808: Requested changes about DateTime

25406e8

2808: Fix translations

3321eb4

steffenkleinle reviewed Sep 10, 2024

View reviewed changes

bahaaTuffaha added 2 commits September 11, 2024 21:22

2808: Requested changes part 2

115de27

Merge remote-tracking branch 'origin' into 2808-Add-a-filter-by-date-…

e652e78

…option-to-events

steffenkleinle reviewed Sep 12, 2024

View reviewed changes

shared/hooks/useDateFilter.ts Outdated Show resolved Hide resolved

bahaaTuffaha added 3 commits September 12, 2024 17:17

2808: Requested changes part 3

000a9a4

2808: Replacing names fromDate and toDate to startDate and endDate

d7ca0ff

2808: Replacing alt with placeholder at date-input (web) for tests ge…

a6176f5

…tByPlaceholderText

bahaaTuffaha marked this pull request as ready for review September 13, 2024 11:11

bahaaTuffaha requested a review from ztefanie as a code owner September 13, 2024 11:11

bahaaTuffaha added 2 commits October 3, 2024 15:12

2808: Dealing with recurrences and adding requested changes

8929238

Merge remote-tracking branch 'origin' into 2808-Add-a-filter-by-date-…

915c099

…option-to-events

steffenkleinle reviewed Oct 10, 2024

View reviewed changes

shared/hooks/useDateFilter.ts Outdated Show resolved Hide resolved

bahaaTuffaha and others added 4 commits October 13, 2024 21:42

2808: Fixing recurrence to show beyond the limit and some refactoring…

a371455

… for Code-Climate

Merge branch 'main' into 2808-Add-a-filter-by-date-option-to-events

df9e206

2808: Importing DateFilterUtils module properly

075d88a

Merge remote-tracking branch 'origin' into 2808-Add-a-filter-by-date-…

87f7daa

…option-to-events

steffenkleinle reviewed Oct 15, 2024

View reviewed changes

2808: Requested changes: general improvements

8ea2492

steffenkleinle approved these changes Oct 16, 2024

View reviewed changes

Merge remote-tracking branch 'origin' into 2808-Add-a-filter-by-date-…

ab81a63

…option-to-events

ztefanie previously requested changes Oct 21, 2024

View reviewed changes

LeandraH reviewed Oct 25, 2024

View reviewed changes

bahaaTuffaha added 7 commits November 1, 2024 20:40

2808: Requested changes about moving focus to next input and improvin…

d537677

…g validation

Merge remote-tracking branch 'origin' into 2808-Add-a-filter-by-date-…

2af2efa

…option-to-events

2808: Adding missing spaces

2464cc5

2808: Modified CalendarRangeModal to let you select from or to date i…

a19bb07

…ndividually

2808: small Refactoring

4232588

2808: Jumping backward when backspacing and Adding width for views ju…

f62a0ca

…st for iOS

2808: Expanded on some more tests for DatePicker spec file

dc2a79f

LeandraH reviewed Nov 5, 2024

View reviewed changes

		justify-content: ${props => (props.theme.contentDirection === 'rtl' ? 'flex-start' : 'flex-end')};
		flex-direction: ${props => (props.theme.contentDirection === 'rtl' ? 'row-reverse' : 'row')};

	const title = `${t('resetFilter')} ${startDate?.toLocal().toFormat('dd.MM.yyyy') ?? '∞'} - ${endDate?.toLocal().toFormat('dd.MM.yyyy') ?? '∞'}`
	const title = `${t('resetFilter')} ${startDate?.toLocaleString({ day: '2-digit', month: '2-digit', year: 'numeric' } ?? '∞'} - ${endDate?.toLocaleString({ day: '2-digit', month: '2-digit', year: 'numeric' } ?? '∞'}`

2808: Add a filter by date option to events #2898

Are you sure you want to change the base?

2808: Add a filter by date option to events #2898

Conversation

bahaaTuffaha commented Aug 27, 2024

Short description

Proposed changes

Side effects

Resolved issues

steffenkleinle left a comment

Choose a reason for hiding this comment

steffenkleinle commented Sep 12, 2024 • edited Loading

steffenkleinle commented Sep 12, 2024

bahaaTuffaha commented Sep 12, 2024

steffenkleinle left a comment

Choose a reason for hiding this comment

steffenkleinle left a comment • edited Loading

Choose a reason for hiding this comment

steffenkleinle left a comment

Choose a reason for hiding this comment

codeclimate bot commented Oct 16, 2024

ztefanie left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steffenkleinle commented Oct 21, 2024

ztefanie commented Oct 21, 2024

steffenkleinle commented Oct 21, 2024

bahaaTuffaha commented Oct 21, 2024 • edited Loading

ztefanie commented Oct 24, 2024

LeandraH left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LeandraH Nov 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LeandraH commented Oct 30, 2024

LeandraH commented Oct 30, 2024

LeandraH left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LeandraH Nov 5, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

steffenkleinle commented Sep 12, 2024 •

edited

Loading

steffenkleinle left a comment •

edited

Loading

bahaaTuffaha commented Oct 21, 2024 •

edited

Loading

LeandraH left a comment •

edited

Loading

LeandraH Nov 5, 2024 •

edited

Loading

LeandraH Nov 5, 2024 •

edited

Loading