2575: Focus trap bottom action sheet #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1sh1918
requested review from
steffenkleinle,
sarahsporck,
ztefanie and
LeandraH
as code owners
f1sh1918
force-pushed
the
2575-focus-trap-bottom-action-sheet
branch
from
5f069a5 to
36d41e3
Compare
steffenkleinle
approved these changes
Nov 21, 2023
web/src/components/Modal.tsx
Outdated
| @@ -62,9 +62,9 @@ const Modal = ({ title, closeModal, children, direction, wrapInPortal = false }: | |||
|
|
|||
| return () => layoutElement?.setAttribute('aria-hidden', 'false') | |||
| }, []) | |||
|
|
|||
| // display check option is needed for portals - https://github.com/focus-trap/tabbable/blob/master/CHANGELOG.md#532 | |||
There was a problem hiding this comment.
I think you linked the wrong release, shouldnt it be https://github.com/focus-trap/tabbable/blob/master/CHANGELOG.md#600?
It says
restore old (incorrect) behavior
Should we investigate a better fix?
There was a problem hiding this comment.
Gonna adjust the link.
I just investigated some time and i didn't find an easy solution. The trap works well with this option, so no idea if its really worth to investigate more time @steffenkleinle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Focus trap lib since
10.xcan not detect nodes from a portal (bottom action sheet) and will throw an error (opening feedback modal)Proposed changes
Side effects
Resolved issues
Fixes: #2575