2543: Remove poi list horizontal scroll bar #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunars97
requested review from
steffenkleinle,
sarahsporck,
ztefanie,
f1sh1918 and
LeandraH
as code owners
lunars97
changed the title
LeandraH
reviewed
Nov 7, 2023
lunars97
force-pushed
the
2543-poi-panel-scrollable-horizontally
branch
from
1b6c540 to
47ba719
Compare
ztefanie
reviewed
Nov 8, 2023
LeandraH
approved these changes
Nov 8, 2023
f1sh1918
reviewed
Nov 8, 2023
f1sh1918
reviewed
Nov 8, 2023
web/src/components/PoiListItem.tsx
Outdated
| @@ -53,7 +53,9 @@ export const Description = styled.div` | |||
| flex-grow: 1; | |||
| padding: 0 22px; | |||
| align-self: center; | |||
| word-wrap: break-word; | |||
| overflow-wrap: break-word; | |||
There was a problem hiding this comment.
don't think this is needed. Couldn't find an issue in chrome nor firefox
f1sh1918
reviewed
Nov 8, 2023
web/src/components/PoiListItem.tsx
Outdated
| @@ -53,7 +53,9 @@ export const Description = styled.div` | |||
| flex-grow: 1; | |||
| padding: 0 22px; | |||
| align-self: center; | |||
| word-wrap: break-word; | |||
| overflow-wrap: break-word; | |||
| word-break: break-word; /* needed for Mozilla support */ | |||
There was a problem hiding this comment.
Suggested change
| word-break: break-word; /* needed for Mozilla support */ | |
| word-break: break-word; |
if overflow-wrap is not needed you can remove comment here
f1sh1918
approved these changes
Nov 8, 2023
…igitalfabrik/integreat-app into 2543-poi-panel-scrollable-horizontally
lunars97
force-pushed
the
2543-poi-panel-scrollable-horizontally
branch
from
47ba719 to
4fac0a6
Compare
excellent work! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
There is a horizontal scroll bar on Poi List Items on web. There should not be any horizontal scroll bar.
Steps to reproduce
Side effects
none
Resolved issues
Fixes: #2543