Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2026: Use global jest configuration #2528

Merged
merged 2 commits into from
Oct 18, 2023
Merged

2026: Use global jest configuration #2528

merged 2 commits into from
Oct 18, 2023

Conversation

sarahsporck
Copy link
Contributor

Short description

This one has a similar reasoning as #2526 . We can basically use jest projects, to combine global jest configs, run all tests together and simplify ci

Proposed changes

  • use jest projects
  • combine global jest configs (such as coverage)
  • run all tests together in ci

Resolved issues

Relates: #2026

@sarahsporck sarahsporck mentioned this pull request Oct 17, 2023
Closed
ztefanie
ztefanie approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@ztefanie ztefanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, i like it.

As on main files not being covered by any test like e.g. native/src/components/base/ChipButton.tsx are not in the report. Is there a way to have them in the report with a coverage of 0%?

@sarahsporck
Copy link
Contributor Author

I added collectCoverageFrom glob pattern that now specifies that all src folders need to be covered. Nice find!

@sarahsporck sarahsporck enabled auto-merge October 18, 2023 07:33
@sarahsporck sarahsporck merged commit f8ca03a into main Oct 18, 2023
@sarahsporck sarahsporck deleted the 2026-global-jest-config branch October 18, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeandraH LeandraH LeandraH approved these changes

@ztefanie ztefanie ztefanie approved these changes

@steffenkleinle steffenkleinle Awaiting requested review from steffenkleinle steffenkleinle is a code owner

@f1sh1918 f1sh1918 Awaiting requested review from f1sh1918 f1sh1918 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarahsporck @ztefanie @LeandraH