Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2491: Make paddings and icons in poi details consistent #2492

Merged
merged 3 commits into from
Oct 4, 2023
Merged

2491: Make paddings and icons in poi details consistent #2492

merged 3 commits into from
Oct 4, 2023

Conversation

steffenkleinle
Copy link
Member

Short description

This unifies the used paddings in the different poi detail sections.

Proposed changes

  • Content of sections does not have horizontal padding anymore per default (exception: right padding for opening hours to align with header geöffnet)
  • Icon sizes unified (address marker size increased, external link size decreased)
  • Refactoring: Collapsible was using the props wrong way round (initial collapsed made the content NOT being collapsed) and extended to make it more customizable
  • Introduced style helper function for adaptiveFontSize

Side effects

  • Usage of Collapsible changed

Resolved issues

Fixes: #2491.

steffenkleinle
steffenkleinle commented Oct 2, 2023
View reviewed changes
web/src/components/Collapsible.tsx
<CollapsibleHeader
role='button'
onClick={() => setCollapsed(!collapsed)}
tabIndex={0}
onKeyPress={() => setCollapsed(!collapsed)}>
<Title>{title}</Title>
onKeyUp={() => setCollapsed(!collapsed)}>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was deprecated

@steffenkleinle steffenkleinle force-pushed the 2491-consistent-poi-paddings branch from f320e12 to 837151f Compare October 2, 2023 13:02
@steffenkleinle steffenkleinle force-pushed the 2491-consistent-poi-paddings branch from 837151f to 44068c9 Compare October 2, 2023 13:05
LeandraH
LeandraH approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@LeandraH LeandraH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Tested in Firefox

release-notes/2023.10.0/2491-consistent-poi-paddings.yml Outdated Show resolved Hide resolved
f1sh1918
f1sh1918 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

I just think if the collapsible is closed it could be centered within the dividers

image

@steffenkleinle
Copy link
Member Author

Looks great

I just think if the collapsible is closed it could be centered within the dividers

@f1sh1918 do you want to check again if you like the solution?

@f1sh1918
Copy link
Contributor

f1sh1918 commented Oct 4, 2023

Looks great
I just think if the collapsible is closed it could be centered within the dividers

@f1sh1918 do you want to check again if you like the solution?

looks super nice. You can merge @steffenkleinle

@steffenkleinle steffenkleinle merged commit f411105 into main Oct 4, 2023
4 checks passed
@steffenkleinle steffenkleinle deleted the 2491-consistent-poi-paddings branch October 4, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f1sh1918 f1sh1918 f1sh1918 approved these changes

@LeandraH LeandraH LeandraH approved these changes

@sarahsporck sarahsporck Awaiting requested review from sarahsporck

@ztefanie ztefanie Awaiting requested review from ztefanie ztefanie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Paddings and icon sizes in poi details are not consistent
3 participants
@steffenkleinle @f1sh1918 @LeandraH