Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2445: Update translations #2483

Closed
wants to merge 6 commits into from
Closed

2445: Update translations #2483

wants to merge 6 commits into from

Conversation

ztefanie
Copy link
Member

@ztefanie ztefanie commented Sep 27, 2023

Short description

Update translations

Proposed changes

  • Fix errors in translations.json
  • Decide for a solution to handle shelter translations
  • Add recurring events translations
  • Send constants to translators
  • Import new translations

Resolved issues

Fixes: #2445


@ztefanie ztefanie changed the title 2445: Fix errors in translations.json 2445: Update translations Sep 28, 2023
Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you perhaps include the constants from #2031? I opened a PR here: #2486. Thanks 🙏

"bed": "1 postel",
"beds": "{{beds}} postele",
"bed_one": "1 postel",
"bed_other": "{{beds}} postele",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be {{count}} actually, could you please change all occurrences?
https://www.i18next.com/translation-function/plurals

Edit: Nvm, we'll remove the shelter constants anyway.

@ztefanie
Copy link
Member Author

Closed, see new translations in #2560

@ztefanie ztefanie closed this Nov 14, 2023
@steffenkleinle
Copy link
Member

@ztefanie is the branch still needed or can it be deleted?

@ztefanie
Copy link
Member Author

@steffenkleinle lets keep it until our Portuguese translations are imported correctly.

@ztefanie ztefanie deleted the 2445-update-translations branch November 22, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate app constants
2 participants