Upgrade ktlint-gradle #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-markl
force-pushed
the
adjust-ktlint
branch
from
1e76429 to
c93a1d7
Compare
sarahsporck
approved these changes
Apr 3, 2023
whats the benefit in omission of leading commas? |
|
Feel free to merge whenever you feel like it (I dont want to create too many conflicts with this right now) :D |
Imo, there's no benefit in having them vs not having them. It's just the default. Having a rule that enforces one or the other is good, so random code style adjustments don't clutter PRs. |
f1sh1918
approved these changes
Apr 3, 2023
# Conflicts: # backend/src/main/kotlin/app/ehrenamtskarte/backend/application/database/Setup.kt # backend/src/main/kotlin/app/ehrenamtskarte/backend/auth/database/Setup.kt # backend/src/main/kotlin/app/ehrenamtskarte/backend/projects/database/Setup.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some difference in kotlin formatting in our local setups throughout the past PRs.
This upgrades ktlint-gradle and e.g. forces the omission of trailing comma, etc.