910: Separate error message for network errors #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sarahsporck
force-pushed
the
910-broken-error-page
branch
from
09c4e83 to
ce7ce28
Compare
sarahsporck
commented
Mar 31, 2023
Comment on lines
-21
to
-24
| onError: error => { | ||
| console.error(error) | ||
| enqueueSnackbar('Etwas ist schief gelaufen.', { variant: 'error' }) | ||
| }, |
There was a problem hiding this comment.
We already implement error handling below.
michael-markl
approved these changes
Apr 1, 2023
|
|
||
| if (error.networkError) { | ||
| return { title: 'Server nicht erreichbar.' } | ||
| } |
There was a problem hiding this comment.
Additionally, please adjust below:
if (error.graphQLErrors.length < 1 || (error.graphQLErrors.length > 1 && !codesEqual)) {
sarahsporck
force-pushed
the
910-broken-error-page
branch
from
ce7ce28 to
425044d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May be improved in the overall error handling PR.