877: Link checker #878
Merged
877: Link checker #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ain/kotlin/app/ehrenamtskarte/backend/auth/webservice/schema/ResetPasswordMutationService.kt
Outdated
Show resolved
Hide resolved
...c/main/kotlin/app/ehrenamtskarte/backend/auth/webservice/schema/ResetPasswordQueryService.kt
Outdated
Show resolved
Hide resolved
f1sh1918
force-pushed
the
677-link-checker
branch
from
ee2cf26 to
2969b49
Compare
administration/src/components/applications/ApplicationApplicantController.tsx
Outdated
Show resolved
Hide resolved
...c/main/kotlin/app/ehrenamtskarte/backend/auth/webservice/schema/ResetPasswordQueryService.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
...c/main/kotlin/app/ehrenamtskarte/backend/auth/webservice/schema/ResetPasswordQueryService.kt
Outdated
Show resolved
Hide resolved
administration/src/components/applications/ApplicationApplicantController.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
# Conflicts: # administration/src/application-verification/VerificationController.tsx # administration/src/components/applications/ApplicationApplicantController.tsx
michael-markl
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
More and more, I have the feeling that using the graphql errors (and extending them to more endpoints) leads to unintuitive, intransparent code (especially in the error handling in the frontends, but also in the backend)...
We can merge this PR, but I feel like in #873 we should analyze whether proper return types might be a better fit for us.
administration/src/components/applications/ApplicationApplicantController.tsx
Outdated
Show resolved
Hide resolved
administration/src/application-verification/VerificationController.tsx
Outdated
Show resolved
Hide resolved
administration/src/application-verification/VerificationController.tsx
Outdated
Show resolved
Hide resolved
administration/src/components/applications/ApplicationApplicantController.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
administration/src/components/applications/InvalidLinkTemplate.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added the link checker to reset password that checks if resetKey exists and the link is not expired.
Added for applicant and verification view an empty collection check
resolves #877