Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small backend fixes #845

Merged
merged 3 commits into from
Mar 3, 2023
Merged

Small backend fixes #845

merged 3 commits into from
Mar 3, 2023

Conversation

michael-markl
Copy link
Member

This PR fixes a few small annoyances

  • Order regions and admins in queries
  • Start webservice only once all handlers are configured (helpful if their configuration errors)
  • Log all SQL queries in dev mode

transaction {
if (!config.production) {
addLogger(StdOutSqlLogger)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is removed, how are queries logged?

Copy link
Member Author

@michael-markl michael-markl Mar 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed logging for this specific transaction, but added logging for all transactions by specifying the DatabaseConfig

@michael-markl michael-markl merged commit 281588a into main Mar 3, 2023
@michael-markl michael-markl deleted the small-backend-fixes branch March 3, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants