Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dev tool to add a card #680

Merged
merged 9 commits into from
Jan 9, 2023
Merged

Add dev tool to add a card #680

merged 9 commits into from
Jan 9, 2023

Conversation

maxammann
Copy link
Member

@maxammann maxammann commented Dec 20, 2022 •
edited
Loading

  • Self verify button
  • option to add card in About tab
  • Fixed endless loading spinner
  • Fixed broken card verification

f1sh1918
f1sh1918 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@f1sh1918 f1sh1918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on ios simulator without code review. Works fine :)

michael-markl
michael-markl approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@michael-markl michael-markl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only code review.

frontend/lib/verification/verification_qr_scanner_page.dart Show resolved Hide resolved
frontend/lib/about/dev_settings_view.dart Outdated Show resolved Hide resolved
frontend/lib/about/dev_settings_view.dart Outdated Show resolved Hide resolved
frontend/lib/about/dev_settings_view.dart Outdated Show resolved Hide resolved
@maxammann @michael-markl
Change labels
b55de09 
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
@maxammann maxammann enabled auto-merge January 9, 2023 09:20
@maxammann maxammann merged commit 9e8ce7c into whitelabel Jan 9, 2023
@maxammann maxammann deleted the base64-card branch January 9, 2023 09:34
@maxammann maxammann mentioned this pull request Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-markl michael-markl michael-markl approved these changes

@f1sh1918 f1sh1918 f1sh1918 approved these changes

@sarahsporck sarahsporck Awaiting requested review from sarahsporck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxammann @michael-markl @f1sh1918