Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

638: Per region app policy #647

Merged
merged 32 commits into from
Dec 14, 2022
Merged

638: Per region app policy #647

merged 32 commits into from
Dec 14, 2022

Conversation

f1sh1918
Copy link
Contributor

@f1sh1918 f1sh1918 commented Nov 29, 2022

Find the acceptance criteria and technical tasks to check if everything works as expected here

Testing requires a Drop table of regions table and reimport (at least in couldn't find better solution)

@f1sh1918 f1sh1918 requested a review from maxammann as a code owner November 29, 2022 13:51
@maxammann maxammann self-requested a review December 4, 2022 11:39
@maxammann
Copy link
Member

(Not tested yet)

f1sh1918 and others added 5 commits December 5, 2022 16:52
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
…service/schema/RegionsQueryService.kt

Co-authored-by: Michael Markl <marklmichael98@gmail.com>
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
@f1sh1918 f1sh1918 force-pushed the 638-per-region-app-policy branch from 26ecef8 to e5d1a06 Compare December 5, 2022 16:10
f1sh1918 and others added 3 commits December 12, 2022 17:42
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
Copy link
Member

@maxammann maxammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for the missing length check of the privacy policy text.

@f1sh1918 f1sh1918 force-pushed the 638-per-region-app-policy branch from f72f590 to d8b9980 Compare December 13, 2022 14:50
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
@sarahsporck sarahsporck linked an issue Dec 14, 2022 that may be closed by this pull request
12 tasks
…app-policy

# Conflicts:
#	administration/src/App.tsx
#	administration/src/application/components/ApplyController.tsx
#	administration/src/components/home/HomeController.tsx
#	backend/src/main/kotlin/app/ehrenamtskarte/backend/auth/service/Authorizer.kt
Copy link
Member

@michael-markl michael-markl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice now!

@michael-markl
Copy link
Member

@f1sh1918 I've just triggered the CI pipeline... somehow auto-triggering CircleCI is broken

f1sh1918 and others added 2 commits December 14, 2022 13:17
@f1sh1918 f1sh1918 enabled auto-merge December 14, 2022 12:22
@f1sh1918 f1sh1918 merged commit 9e54e17 into whitelabel Dec 14, 2022
@f1sh1918 f1sh1918 deleted the 638-per-region-app-policy branch December 14, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per Region Privacy policy
3 participants