-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
638: Per region app policy #647
Conversation
… to apply for eak, fix reload document on region NavLink, add route for data-privacy-policy with base policy
administration/src/application/components/forms/ApplicationForm.tsx
Outdated
Show resolved
Hide resolved
administration/src/application/components/forms/ApplicationForm.tsx
Outdated
Show resolved
Hide resolved
.../src/main/kotlin/app/ehrenamtskarte/backend/regions/webservice/schema/RegionsQueryService.kt
Outdated
Show resolved
Hide resolved
administration/src/application/components/forms/ApplicationForm.tsx
Outdated
Show resolved
Hide resolved
administration/src/application/components/forms/ApplicationForm.tsx
Outdated
Show resolved
Hide resolved
backend/src/main/kotlin/app/ehrenamtskarte/backend/regions/database/repos/RegionsRepository.kt
Show resolved
Hide resolved
...c/main/kotlin/app/ehrenamtskarte/backend/regions/webservice/schema/RegionsMutationService.kt
Show resolved
Hide resolved
(Not tested yet) |
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
…service/schema/RegionsQueryService.kt Co-authored-by: Michael Markl <marklmichael98@gmail.com>
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
26ecef8
to
e5d1a06
Compare
…app-policy # Conflicts: # administration/src/application/components/ApplyController.tsx # administration/src/application/components/forms/ApplicationForm.tsx
…r privacyPolicy textarea
administration/src/application/components/forms/StepSendForm.tsx
Outdated
Show resolved
Hide resolved
administration/src/application/components/primitive-inputs/CheckboxForm.tsx
Outdated
Show resolved
Hide resolved
...c/main/kotlin/app/ehrenamtskarte/backend/regions/webservice/schema/RegionsMutationService.kt
Show resolved
Hide resolved
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me except for the missing length check of the privacy policy text.
…taPolicyQuery, add apollo fetch policy
f72f590
to
d8b9980
Compare
administration/src/application/components/primitive-inputs/CheckboxForm.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
…app-policy # Conflicts: # administration/src/App.tsx # administration/src/application/components/ApplyController.tsx # administration/src/components/home/HomeController.tsx # backend/src/main/kotlin/app/ehrenamtskarte/backend/auth/service/Authorizer.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice now!
@f1sh1918 I've just triggered the CI pipeline... somehow auto-triggering CircleCI is broken |
Co-authored-by: Michael Markl <marklmichael98@gmail.com>
Find the acceptance criteria and technical tasks to check if everything works as expected here
Testing requires a Drop table of
regions
table and reimport (at least in couldn't find better solution)