Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Administration] Upgrade npm packages and use new GraphQL code generator #558

Merged
merged 5 commits into from
Sep 20, 2022

Conversation

michael-markl
Copy link
Member

No description provided.

Copy link
Member

@maxammann maxammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet tested.

"generate-protobuf:win32": "mkdir src\\generated | pbjs -t static-module -w es6 -o src\\generated\\compiled.js ..\\specs\\card_activate_model.proto --force-long | pbts -o src\\generated\\compiled.d.ts src\\generated\\compiled.js",
"postinstall": "npm run generate-protobuf"
"generate-protobuf:linux": "mkdir -p src/generated && pbjs -t static-module -w es6 -o src/generated/protobuf.js ../specs/card_activate_model.proto --force-long && pbts -o src/generated/protobuf.d.ts src/generated/protobuf.js",
"generate-protobuf:win32": "mkdir src\\generated | pbjs -t static-module -w es6 -o src\\generated\\protobuf.js ..\\specs\\card_activate_model.proto --force-long | pbts -o src\\generated\\protobuf.d.ts src\\generated\\protobuf.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove that? Only difference is backslashes. WSL should handle that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just keep it for now until it breaks something for us.

@maxammann
Copy link
Member

Merge if you feel comfortable.

@michael-markl
Copy link
Member Author

The only thing I am uncomfortable with is the annoying issue zxing-js/library#499 which makes the zxing library shout a huge number of warnings (involving source maps) when building.

@maxammann
Copy link
Member

The only thing I am uncomfortable with is the annoying issue zxing-js/library#499 which makes the zxing library shout a huge number of warnings (involving source maps) when building.

I left a comment in that issue to give it a bump. I would say we just merge with warnings and ignore them. Having warnings is better than not having source maps :D

@michael-markl
Copy link
Member Author

Seems good to me!

@michael-markl michael-markl merged commit eb0d3ea into whitelabel Sep 20, 2022
@michael-markl michael-markl deleted the update-administration branch September 20, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants