-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1175: Language switch #1197
1175: Language switch #1197
Conversation
c7bf4e9
to
5aa21d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on android, works nicely!
One thing I noticed (not introduced in your PR though): If you click on Change language
, the button does not show the touch. Once navigating back to the about screen/closing the language switch, the button then shows the touch.
Hm i think i don't understand what you mean.. |
6f7f8c1
to
a0b82b2
Compare
See attached video. The "onTouch" animation is only shown when coming back from the language switch screen, not directly on touch. Perhaps thats also intended though. screen-20231108-151321.mp4 |
okay thats weird. you can create an issue for that. don't think that relies to my pr |
Sure, I can do that. Can you reproduce that? |
yes that seem to happen for all |
Short description
Since translations are available, the user want to switch the language in the app
Proposed changes
Resolved issues
Fixes: #1175