Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1175: Language switch #1197

Merged
merged 4 commits into from
Nov 9, 2023
Merged

1175: Language switch #1197

merged 4 commits into from
Nov 9, 2023

Conversation

f1sh1918
Copy link
Contributor

@f1sh1918 f1sh1918 commented Nov 7, 2023

Short description

Since translations are available, the user want to switch the language in the app

Proposed changes

  • added a settings section with a language change
  • adjusted the tabItem for sozialpass
  • added a notification (found it nicer to get a feedback)

Resolved issues

Fixes: #1175

@f1sh1918 f1sh1918 marked this pull request as ready for review November 7, 2023 16:45
@f1sh1918 f1sh1918 force-pushed the 1175-language-switch branch from c7bf4e9 to 5aa21d3 Compare November 7, 2023 16:48
Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on android, works nicely!
One thing I noticed (not introduced in your PR though): If you click on Change language, the button does not show the touch. Once navigating back to the about screen/closing the language switch, the button then shows the touch.

frontend/assets/l10n/app_de.json Outdated Show resolved Hide resolved
frontend/build-configs/bayern/index.ts Outdated Show resolved Hide resolved
frontend/lib/about/about_page.dart Outdated Show resolved Hide resolved
frontend/lib/about/about_page.dart Show resolved Hide resolved
@f1sh1918
Copy link
Contributor Author

f1sh1918 commented Nov 8, 2023

Tested on android, works nicely! One thing I noticed (not introduced in your PR though): If you click on Change language, the button does not show the touch. Once navigating back to the about screen/closing the language switch, the button then shows the touch.

Hm i think i don't understand what you mean..
Updated pr with your suggestions and changed the identity logo as it was changed in design

@steffenkleinle
Copy link
Member

Tested on android, works nicely! One thing I noticed (not introduced in your PR though): If you click on Change language, the button does not show the touch. Once navigating back to the about screen/closing the language switch, the button then shows the touch.

Hm i think i don't understand what you mean.. Updated pr with your suggestions and changed the identity logo as it was changed in design

See attached video. The "onTouch" animation is only shown when coming back from the language switch screen, not directly on touch. Perhaps thats also intended though.

screen-20231108-151321.mp4

@f1sh1918
Copy link
Contributor Author

f1sh1918 commented Nov 8, 2023

Tested on android, works nicely! One thing I noticed (not introduced in your PR though): If you click on Change language, the button does not show the touch. Once navigating back to the about screen/closing the language switch, the button then shows the touch.

Hm i think i don't understand what you mean.. Updated pr with your suggestions and changed the identity logo as it was changed in design

See attached video. The "onTouch" animation is only shown when coming back from the language switch screen, not directly on touch. Perhaps thats also intended though.

screen-20231108-151321.mp4

okay thats weird. you can create an issue for that. don't think that relies to my pr

@steffenkleinle
Copy link
Member

Tested on android, works nicely! One thing I noticed (not introduced in your PR though): If you click on Change language, the button does not show the touch. Once navigating back to the about screen/closing the language switch, the button then shows the touch.

Hm i think i don't understand what you mean.. Updated pr with your suggestions and changed the identity logo as it was changed in design

See attached video. The "onTouch" animation is only shown when coming back from the language switch screen, not directly on touch. Perhaps thats also intended though.
screen-20231108-151321.mp4

okay thats weird. you can create an issue for that. don't think that relies to my pr

Sure, I can do that. Can you reproduce that?

@f1sh1918
Copy link
Contributor Author

f1sh1918 commented Nov 8, 2023

Tested on android, works nicely! One thing I noticed (not introduced in your PR though): If you click on Change language, the button does not show the touch. Once navigating back to the about screen/closing the language switch, the button then shows the touch.

Hm i think i don't understand what you mean.. Updated pr with your suggestions and changed the identity logo as it was changed in design

See attached video. The "onTouch" animation is only shown when coming back from the language switch screen, not directly on touch. Perhaps thats also intended though.
screen-20231108-151321.mp4

okay thats weird. you can create an issue for that. don't think that relies to my pr

Sure, I can do that. Can you reproduce that?

yes that seem to happen for all ContentTile components only on android

@f1sh1918 f1sh1918 merged commit ec106a9 into main Nov 9, 2023
@f1sh1918 f1sh1918 deleted the 1175-language-switch branch November 9, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sozialpass] Setup a switch for the app language
2 participants