1029: proposal empty map auto screenshot #1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f1sh1918
approved these changes
Nov 6, 2023
| @@ -17,7 +16,14 @@ class ScreenshotTests: XCTestCase { | |||
|
|
|||
| } | |||
|
|
|||
| func waitForElementToAppear(element: XCUIElement, timeout: TimeInterval = 20, file: String = #file, line: UInt = #line) { | |||
| func getBundleId(from app: XCUIApplication) -> String { | |||
There was a problem hiding this comment.
well thats nice. I also wanted to implement it that way but my swift skills reached their limit :)
| desc "Generate new localized screenshots" | ||
| lane :screenshots do | ||
| capture_screenshots(workspace: "Runner.xcworkspace", scheme: "ScreenshotTests") | ||
| lane :snap_bayern do |
There was a problem hiding this comment.
thats way better, didn't find that lane functionality! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
I moved the commands into the fastfile, as it is pretty hard to write out the whole command you proposed in the command line. Besides that I have had issues with active support (which I didn't commit), didn't you have the same problem? -> fastlane/fastlane#21585
Proposed changes