Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1114: Sort applications by status #1117

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Conversation

f1sh1918
Copy link
Contributor

@f1sh1918 f1sh1918 commented Sep 6, 2023

resolves #1114

Please properly test the sorting by creating some applications with different status.
Applications that are not fully approved or rejected will have the status "waiting" and put in the end, since they are not actionable

@f1sh1918 f1sh1918 changed the title 1114: add function to sort applications by status 1114: Sort applications by status Sep 6, 2023
@f1sh1918 f1sh1918 force-pushed the 1114-Sort-applications-by-status branch from 94cdd66 to f3e0b61 Compare September 6, 2023 20:27
@f1sh1918 f1sh1918 force-pushed the 1114-Sort-applications-by-status branch from 60ec308 to 5f583e4 Compare September 7, 2023 11:31
Copy link
Member

@michael-markl michael-markl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested

Comment on lines 2 to +9
"name": "administration",
"version": "3.1.5",
"version": "3.2.0",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "administration",
"version": "3.1.5",
"version": "3.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this change should be in this PR.

@f1sh1918 f1sh1918 merged commit 79d9a0d into main Sep 7, 2023
@f1sh1918 f1sh1918 deleted the 1114-Sort-applications-by-status branch September 7, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort applications by status
2 participants