1082: Prefill card form from query params #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahsporck
changed the title
f1sh1918
approved these changes
Aug 17, 2023
| cardBlueprint.setValue(header, value) | ||
| }) | ||
| setCardBlueprints([cardBlueprint]) | ||
| setSearchParams() |
There was a problem hiding this comment.
Hm it might be better to clean the searchParams after creating barcodes?
On the other hand f.e. a logout doesn't trigger cleaning.
There was a problem hiding this comment.
I thought it makes sense to remove the searchParams imediately to not accidentally refill the form with values. So I'd keep it.
| @@ -42,6 +44,24 @@ type CreateCardsFormProps = { | |||
|
|
|||
| const CreateCardsForm = ({ region, cardBlueprints, setCardBlueprints }: CreateCardsFormProps) => { | |||
| const projectConfig = useContext(ProjectConfigContext) | |||
| // http://localhost:3000/cards/add?name=Thea+Test& | |||
| @@ -69,6 +88,15 @@ export class CardBlueprint { | |||
| return this.expirationDate !== null && this.expirationDate.isAfter(today) | |||
| } | |||
|
|
|||
| setExpirationDate = (value: string) => { | |||
| if (value.length === 0) return null | |||
There was a problem hiding this comment.
Suggested change
| if (value.length === 0) return null | |
| if (value.length === 0) return |
i think this should be fine without null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few examples:
I'd really like to add tests for this, but I think we need to migrate to jest for this.
Mind that you can now cheesily set the Adressvalues, when passing them as query params, but I don't think we need to prohibit that, as it (1) adds more complexity to this and (2) will be unknown to our users as long as we don't tell them :D