Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port integration test for collection_save_csv from digital-land-airflow #90

Merged

Conversation

Staberinde
Copy link
Contributor

Porting test in separate PR to fix for https://trello.com/c/8SkT6vSR/2283-resolve-missing-bytes-and-start-date-in-resourcecsv-data to keep the PR size down

@Staberinde Staberinde force-pushed the 2283-resolve-missing-bytes-and-start-date-in-resourcecsv-data branch 3 times, most recently from 556c57c to f1072a3 Compare April 8, 2022 15:07
@Staberinde Staberinde force-pushed the 2283-resolve-missing-bytes-and-start-date-in-resourcecsv-data branch from f1072a3 to 75e0d81 Compare April 8, 2022 15:10
@codecov-commenter
Copy link

Codecov Report

Merging #90 (75e0d81) into main (be8acf8) will increase coverage by 0.98%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   68.43%   69.42%   +0.98%     
==========================================
  Files          61       61              
  Lines        2636     2636              
==========================================
+ Hits         1804     1830      +26     
+ Misses        832      806      -26     
Impacted Files Coverage Δ
digital_land/api.py 61.90% <0.00%> (+4.16%) ⬆️
digital_land/collection.py 73.97% <0.00%> (+6.16%) ⬆️
digital_land/store/csv.py 96.55% <0.00%> (+34.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8acf8...75e0d81. Read the comment docs.

@Staberinde Staberinde merged commit 173f944 into main Apr 12, 2022
@ernest-tpximpact ernest-tpximpact deleted the 2283-resolve-missing-bytes-and-start-date-in-resourcecsv-data branch September 22, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants