Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable echo in daml wrapper script #655

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Disable echo in daml wrapper script #655

merged 1 commit into from
Apr 24, 2019

Conversation

cocreature
Copy link
Contributor

When echo is enabled (which is the default), the IDE can get really
confused since it tries to interpret the commands as LSP messages
which obviously fails.

Pull Request Checklist

NOTE: CI is not automatically run on non-members pull-requests for security
reasons. The reviewer will have to comment with /AzurePipelines run to
trigger the build.

@cocreature cocreature requested review from a user and neil-da April 24, 2019 11:01
@cocreature cocreature force-pushed the ide-fixes branch 2 times, most recently from ae92caa to ce00080 Compare April 24, 2019 11:13
Copy link
Contributor

@neil-da neil-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both good ideas

Copy link
Contributor

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cocreature cocreature force-pushed the ide-fixes branch 3 times, most recently from a2ba451 to 83c6393 Compare April 24, 2019 17:38
When echo is enabled (which is the default), the IDE can get really
confused since it tries to interpret the commands as LSP messages
which obviously fails.
@mergify mergify bot merged commit 1cc0126 into master Apr 24, 2019
@mergify mergify bot deleted the ide-fixes branch April 24, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants