Prefix package name for generated pojos #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnksv
force-pushed
the
move-package-for-generated-pojo
branch
6 times, most recently
from
869e3a6
to
dbdfaae
Compare
post-svejk
approved these changes
Jun 23, 2021
There was a problem hiding this comment.
Ser greit ut. Bør la @eivinhb og/eller @velfundert ta en kikk, og ta stilling til om denne endringen er ok i offentlig repo og som Maven-artefakter. Alternativet er vel å holde det på en privat fork, som kun deployer til vårt interne Maven-repo.
|
It should be easy to test if this has backwards compatibility issues with the client and/or meldingsformidler. If that seems ok, then I see no issues here. |
|
Must bump a major version due to change in package names. Thus clients and MF must change imports to be compatible with the changes introduced in this PR. |
runeflobakk
reviewed
Sep 1, 2021
johnksv
force-pushed
the
move-package-for-generated-pojo
branch
from
dbdfaae
to
6165673
Compare
…s when other pojos from same xsds were on class path
johnksv
force-pushed
the
move-package-for-generated-pojo
branch
from
6165673
to
5016d0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it could cause problems when pojos from same xsds were on class path
Prefix all package names of generated pojos with
no.digipost