feat: type-safe encode function [3/6] #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmaclennan
changed the base branch from
master
to
feat/encode-decode-type-safety
4 tasks
Co-authored-by: tomasciccola <tomasciccola@users.noreply.github.com>
I realize Project has a missing acording to the revition we did called `defaultPresets`. I'll try to add it and see how it goes...
|
Fixes #69 |
gmaclennan
changed the title
gmaclennan
added a commit
that referenced
this pull request
Aug 1, 2023
* WIP: type-safe encode function * WIP: encode function skeleton * feat: start working on lib/encode-conversions.ts, on observation * Add tag conversion for decode Co-authored-by: tomasciccola <tomasciccola@users.noreply.github.com> * feat: convertField and convertProject on encode-converstions.ts I realize Project has a missing acording to the revition we did called `defaultPresets`. I'll try to add it and see how it goes... * feat: add (commented for now) convertPreset to encode-convertions * fix up encode convert functions * Add preset encode/decode --------- Co-authored-by: Tomás Ciccola <tciccola@digital-democracy.com> Co-authored-by: tomasciccola <tomasciccola@users.noreply.github.com>
|
Actual squash-merge commit 11291ce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo (type conversions)
Role,Device,CoreOwnershipto be tackled in follow-up PR once those schemas are finalized.