Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: refactor type to schemaType #41

Merged
merged 1 commit into from
Apr 3, 2023
Merged

feat: refactor type to schemaType #41

merged 1 commit into from
Apr 3, 2023

Conversation

tomasciccola
Copy link
Contributor

To have consistency with schemaVersion I refactored type to schemaType. This also solves the issue of the Field v1 schema that uses type for smth completely different.

This closes issue #37

@tomasciccola tomasciccola self-assigned this Mar 20, 2023
sethvincent
sethvincent approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@sethvincent sethvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me.

@sethvincent sethvincent merged commit 3fdb759 into master Apr 3, 2023
@sethvincent sethvincent deleted the schemaType branch April 3, 2023 15:42
@sethvincent sethvincent mentioned this pull request Apr 3, 2023
Closed
This was referenced Jun 27, 2023
Closed
Closed
Merged
Closed
Merged
Merged
Closed
Closed
Closed
This was referenced Jul 26, 2023
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Aug 3, 2023
Merged
This was referenced Aug 15, 2023
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Aug 23, 2023
Merged
This was referenced Sep 15, 2023
Merged
Closed
This was referenced Sep 28, 2023
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Oct 10, 2023
Merged
This was referenced Oct 25, 2023
Closed
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Feb 14, 2024
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Apr 16, 2024
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request May 15, 2024
Merged
This was referenced Aug 1, 2024
Merged
Merged
Merged
This was referenced Aug 24, 2024
Merged
Merged
Merged
Merged
This was referenced Sep 2, 2024
Merged
Merged
Merged
This was referenced Sep 16, 2024
Merged
Closed
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethvincent sethvincent sethvincent approved these changes

@gmaclennan gmaclennan Awaiting requested review from gmaclennan

Assignees

@tomasciccola tomasciccola

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomasciccola @sethvincent