Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: versioned protobufs #32

Merged
merged 18 commits into from
Mar 7, 2023
Merged

feat: versioned protobufs #32

merged 18 commits into from
Mar 7, 2023

Commits on Feb 14, 2023

  1. feat: minor refactoring. move formatSchemaType to utils.js

    Tomás Ciccola committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    daa2118 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. chore: update schemasPrefix.js

    Tomás Ciccola committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    d2ae537 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Configuration menu
    Copy the full SHA
    cae214d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3e33597 View commit details
    Browse the repository at this point in the history
  3. feat: throw error if invalid type_schemaVersion on decoding

    Tomás Ciccola committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    5668f73 View commit details
    Browse the repository at this point in the history
  4. feat: add formatSchemaType on utils to get key to schemas

    Tomás Ciccola committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    0527860 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Configuration menu
    Copy the full SHA
    4bab3a0 View commit details
    Browse the repository at this point in the history
  2. feat: build versioning of schemas from filesystem instead of on schemas

    This is so that schemas that doesn't have schemaVersion can be generated
    too
    Tomás Ciccola committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    549197e View commit details
    Browse the repository at this point in the history
  3. feat:

    * added optional fields to filter and preset protobufs
    * added field protobuf and schema
    * type is optional on Preset_1 so need to be made optional on base type
      (and deleted before validation)
    * schemaVersion is optional on Field_1 so need to be made optional on
      base type (and deleted before validation)
    * this means utils.js/formatSchema{Key,Type} no takes optional values
    Tomás Ciccola committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    89965ac View commit details
    Browse the repository at this point in the history
  4. chore: solved minor type error

    Tomás Ciccola committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    4348219 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. feat: handle type casing with schemaPrefix

    Casing on a doc type shouldn't be handled specifically by the code. Nevertheless, some schemas enforce a type to a specific value (type must be i.e. 'observation', which is different from 'Observation'). This means that type "observation"  and "Observation" should have different dataTypeIds. That way we know what "type" to fill-in on returning the decoded object to be validated...
    If we want the same `dataTypeId` for 'observation' and 'Observation'
    (since we know we're actually talking about roughly the same type of
    'document'), we could format the schemasPrefix object differently like:
    Observation: `{dataTypeId: '924892', versions: {'observation': 4, 'Observation': 5}}`
    or something less worse...
    Tomás Ciccola committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    17750cf View commit details
    Browse the repository at this point in the history
  2. chore: logic error on inheritsFromCommon

    Tomás Ciccola committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    88653d8 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Configuration menu
    Copy the full SHA
    2193743 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. feat: add coreOwnership and device schema

    Tomás Ciccola committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    ffd7b25 View commit details
    Browse the repository at this point in the history
  2. feat: add schema for role

    Tomás Ciccola committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    760a9fe View commit details
    Browse the repository at this point in the history
  3. feat: add testing for validation of JSONSchema docs

    Tomás Ciccola committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    604161c View commit details
    Browse the repository at this point in the history
  4. feat: created_at is saved as Timestamp on protobuf

    Tomás Ciccola committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    670cc9e View commit details
    Browse the repository at this point in the history
  5. feat: timestamp is saved as Timestamp on protobuf

    Tomás Ciccola committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    4cdcb4a View commit details
    Browse the repository at this point in the history