feat: add self-hosted server details to DeviceInfo
#268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmaclennan
requested changes
Oct 2, 2024
This adds a new object, `selfHostedServerDetails`, to `DeviceInfo`. It currently has one property, `hostname`, but could have more later.
EvanHahn
force-pushed
the
server-selfhostedserverdetails
branch
from
1818a9e
to
ee315e5
Compare
|
Got Gregor's approval separately. Merging (and only into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is made against the
serverbranch, which we won't merge intomainuntil we're ready to deploy this.This adds a new object,
selfHostedServerDetails, toDeviceInfo. It currently has one property,hostname, but could have more later.