add unspecified field to enums #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasciccola
changed the title
gmaclennan
reviewed
Jul 29, 2024
I think you missed the comments on the issue -> https://github.com/digidem/mapeo-schema/issues/171#issuecomment-2252879592 I'm not against of merging this, just, want to understand what I'm missing ... |
EvanHahn
approved these changes
Jul 30, 2024
This was referenced Aug 1, 2024
This was referenced Aug 24, 2024
This was referenced Sep 2, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should close #171.
Instead of having a field "unspecified" for enums, I had to be deliberate (so
${enum_name_in_snake_case}_unspecified) since protobufs don't allow enums to have fields with the same name