-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hash in attachments to observation schema #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure i should have the final say on this but changes lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do the same with this as we do with other fields that are buffers, and store in the protobuf as bytes, and stringify in encode.
Updated the hash property to use bytes in the protobuf schema, and in encode/decode it now has the same behavior as driveId. |
A change to the observation schema to support digidem/comapeo-core#220.