Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hash in attachments to observation schema #140

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

sethvincent
Copy link
Contributor

A change to the observation schema to support digidem/comapeo-core#220.

Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure i should have the final say on this but changes lgtm

Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do the same with this as we do with other fields that are buffers, and store in the protobuf as bytes, and stringify in encode.

@sethvincent
Copy link
Contributor Author

Updated the hash property to use bytes in the protobuf schema, and in encode/decode it now has the same behavior as driveId.

@gmaclennan gmaclennan merged commit c0ee3fd into main Sep 13, 2023
@gmaclennan gmaclennan deleted the observation-attachments-hash branch September 13, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants