Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add optional deleted field to common (proto and schema) #138

Merged
merged 7 commits into from
Sep 27, 2023
Merged

feat: add optional deleted field to common (proto and schema) #138

merged 7 commits into from
Sep 27, 2023

Conversation

tomasciccola
Copy link
Contributor

this would close #84

@tomasciccola tomasciccola self-assigned this Aug 24, 2023
@tomasciccola
Copy link
Contributor Author

I'm wondering how to test an invalid value for the deleted field. On the JSONSchema level we can force deleted to be true but I don't know a way to do it on the protobuf level (maybe with an option ??) @gmaclennan

gmaclennan
gmaclennan requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we make deleted required, it will make all the code easier I think.

gmaclennan
gmaclennan requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness sake there should be a test for when deleted = true

@tomasciccola tomasciccola merged commit 116db1a into main Sep 27, 2023
6 checks passed
@tomasciccola tomasciccola deleted the feat/addDeletedToCommon branch September 27, 2023 14:20
This was referenced Sep 28, 2023
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Oct 10, 2023
Merged
This was referenced Oct 25, 2023
Closed
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Feb 14, 2024
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Apr 16, 2024
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request May 15, 2024
Merged
This was referenced Aug 1, 2024
Merged
Merged
Merged
This was referenced Aug 24, 2024
Merged
Merged
This was referenced Aug 26, 2024
Merged
Merged
Merged
This was referenced Sep 3, 2024
Merged
Merged
This was referenced Sep 16, 2024
Merged
Closed
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmaclennan gmaclennan gmaclennan approved these changes

Assignees

@tomasciccola tomasciccola

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add deleted field to common props
2 participants
@tomasciccola @gmaclennan