Skip to content

Commit

Permalink
fix!: remove isInitialProject from project settings
Browse files Browse the repository at this point in the history
[Gregor rightly pointed out that this value is synced][0]. Given that
this value is currently unused on the frontend, we should remove it.

[0]: digidem/comapeo-core#751 (comment)
  • Loading branch information
EvanHahn committed Sep 10, 2024
1 parent 8f643fc commit 9f9c344
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 8 deletions.
1 change: 0 additions & 1 deletion proto/projectSettings/v1.proto
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,4 @@ message ProjectSettings_1 {
optional DefaultPresets defaultPresets = 2;
optional ConfigMetadata configMetadata = 3;
optional string name = 4;
bool isInitialProject = 5;
}
6 changes: 1 addition & 5 deletions schema/projectSettings/v1.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,8 @@
},
"additionalProperties": false,
"required": ["name", "buildDate", "importDate", "fileVersion"]
},
"isInitialProject": {
"type": "boolean",
"description": "this allows for checking if the user has already joined a project or if its on the initial 'default' project"
}
},
"required": ["schemaName", "isInitialProject"],
"required": ["schemaName"],
"additionalProperties": false
}
1 change: 0 additions & 1 deletion test/fixtures/good-docs-completed.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ export const goodDocsCompleted = [
buildDate: cachedValues.configMetadata.buildDate,
importDate: cachedValues.configMetadata.importDate,
},
isInitialProject: true,
deleted: false,
},
expected: {},
Expand Down
1 change: 0 additions & 1 deletion test/fixtures/good-docs-minimal.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ export const goodDocsMinimal = [
},
links: [],
deleted: false,
isInitialProject: false,
},
expected: {},
},
Expand Down

0 comments on commit 9f9c344

Please sign in to comment.