Always specify DeviceInfo.deviceType

digidem · Sep 11, 2024 · 931f473 · 931f473
1 parent 4cbaf8f
commit 931f473
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/proto/deviceInfo/v1.proto b/proto/deviceInfo/v1.proto
@@ -22,5 +22,5 @@ message DeviceInfo_1 {
   }
 
   string name = 5 [(required) = true];
-  optional DeviceType deviceType = 6;
+  DeviceType deviceType = 6;
 }
diff --git a/src/lib/encode-conversions.ts b/src/lib/encode-conversions.ts
@@ -128,6 +128,7 @@ export const convertDeviceInfo: ConvertFunction<'deviceInfo'> = (mapeoDoc) => {
   return {
     common: convertCommon(mapeoDoc),
     ...mapeoDoc,
+    deviceType: mapeoDoc.deviceType ?? 'device_type_unspecified',
   }
 }
 

diff --git a/test/fixtures/good-docs-minimal.js b/test/fixtures/good-docs-minimal.js
@@ -118,7 +118,7 @@ export const goodDocsMinimal = [
       name: 'my device name',
       deleted: false,
     },
-    expected: {},
+    expected: { deviceType: 'device_type_unspecified' },
   },
   {
     doc: {