Skip to content

Commit

Permalink
chore!: make some Observation props optional (#239)
Browse files Browse the repository at this point in the history
This is a partial revert of 4ce47f0.

Some observation metadata properties are optional, but I accidentally
made them required. This fixes that.
  • Loading branch information
EvanHahn authored Sep 3, 2024
1 parent 1063822 commit 2a5c718
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion proto/observation/v1.proto
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ message Observation_1 {

message Position {
google.protobuf.Timestamp timestamp = 1;
bool mocked = 2;
optional bool mocked = 2;

message Coords {
double latitude = 1;
Expand Down
4 changes: 1 addition & 3 deletions schema/observation/v1.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"position": {
"description": "Position details",
"type": "object",
"required": ["mocked"],
"properties": {
"timestamp": {
"description": "Timestamp of when the current position was obtained",
Expand Down Expand Up @@ -183,8 +182,7 @@
}
}
},
"additionalProperties": false,
"required": ["manualLocation"]
"additionalProperties": false
},
"presetRef": {
"type": "object",
Expand Down

0 comments on commit 2a5c718

Please sign in to comment.