-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rebuild SQLite when project migrations occur #949
Conversation
a9bedfb
to
0e972c4
Compare
0e972c4
to
100bced
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok looks good apart from one code clarity suggestion. However I think we should also include in this re-indexing of the projectSettingsTable
(in MapeoManager
) which I think needs the same treatment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final thoughts, one way of doing this in the future would be to compare just the indexed tables in the sqlite_schema
table, comparing the sql
column, to detect changes. That way we would avoid re-indexing if we change the schema of a table that is not coming from our indexer.
Done in 5084bb2. (I didn't have an easy way to test this so I didn't.)
That's a much better idea. I'll consider doing that in a followup. |
This reverts commit 5084bb2.
See #436.