chore: Send download intent to peers #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHahn
requested changes
Oct 29, 2024
|
|
||
| /** | ||
| * | ||
| * @param {object} opts | ||
| * @param {import('../core-manager/index.js').CoreManager} opts.coreManager | ||
| * @param {CoreOwnership} opts.coreOwnership | ||
| * @param {import('../roles.js').Roles} opts.roles | ||
| * @param {import('../types.js').BlobFilter | null} opts.blobDownloadFilter |
There was a problem hiding this comment.
It seems like we always set this to null. Can we either (1) set the option (2) remove the option?
There was a problem hiding this comment.
This is waiting for #940 to land so we can use the NON_ARCHIVE_DEVICE_FILTER constant for initializing the class. Left it out to avoid creating a dependency on that PR for landing this.
|
We could add temporary tests, which dive into the implementation details and list to events in the core manager, or we can wait until we update sync wants based on the download intents which will enable us to write end-to-end tests. I'm tempted to just wait for e2e tests. |
EvanHahn
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #686