chore: remove paths filter for lockfile workflow #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "Check Lockfile" workflow had a paths filter in the trigger, to only run when package-lock.json is modified. Unfortunately there is an edge-case, where package-lock.json is modified, and the lockfile changes check posts a comment, and then the package-lock.json changes are reverted, but the lockfile changes check does not run again, because now the PR has not updates to `package-lock.json`. This workflow is very fast compared with the other checks in the repo, so I think it's ok to run for every PR sync event.
EvanHahn
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Check Lockfile" workflow had a paths filter
in the trigger, to only run when package-lock.json
is modified. Unfortunately there is an edge-case,
where package-lock.json is modified, and the
lockfile changes check posts a comment, and then
the package-lock.json changes are reverted, but
the lockfile changes check does not run again,
because now the PR has no updates to
package-lock.json.This workflow is very fast compared with the other
checks in the repo, so I think it's ok to run for
every PR sync event.