chore: use more restrictive types for timingSafeEqual
#936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a types-only change. [`crypto.timingSafeEqual`][0] has some subtle behavior (highlighted in bold red in the docs!) when passing a `Float32Array` or `Float64Array`. Rather than adapt our wrapper to support this unusual situation, this updates the types to avoid it. We never took advantage of this unusual case, and now we are even less likely to. [0]: https://nodejs.org/api/crypto.html#cryptotimingsafeequala-b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a types-only change.
crypto.timingSafeEqualhas some subtle behavior (highlighted in bold red in the docs!) when passing aFloat32ArrayorFloat64Array. Rather than adapt our wrapper to support this unusual situation, this updates the types to avoid it.We never took advantage of this unusual case, and now we are even less likely to.
I plan to yolo-merge this if CI passes.