chore: allow any JSON object to be saved in blob store #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blob store will need to store additional metadata, such as audio duration, in the future. This changes its `metadata` type to any JSON object to allow this. It also adds a test for `blobStore.entry()` to ensure metadata is saved. This change shouldn't affect the external API because the blob store is not directly exposed. It's used internally by `BlobApi`, which did not change.
gmaclennan
requested changes
Oct 22, 2024
EvanHahn
force-pushed
the
allow-any-json-object-to-be-saved-in-blobstore
branch
from
8a6390f
to
58dab5b
Compare
gmaclennan
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blob store will need to store additional metadata, such as audio duration, in the future. This changes its
metadatatype to any JSON object to allow this.It also adds a test for
blobStore.entry()to ensure metadata is saved.This change shouldn't affect the external API because the blob store is not directly exposed. It's used internally by
BlobApi, which did not change.