test: invite helper should automatically wait for peers #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHahn
force-pushed
the
invite-should-wait-for-peers
branch
from
3472ca3 to
d5f2b43
Compare
EvanHahn
added a commit
that referenced
this pull request
Sep 24, 2024
`waitForPeers`, a test helper, currently checks that the *number* of connected peers is expected. This has two problems: - If the number of connected peers is *more than needed*, it will never resolve. - If the *number* of connected peers is correct but the actual peers are different, the promise could resolve prematurely. This snippet highlights the problem: ```javascript const managers = await createManagers(3, t) const [a, b, c] = managers connectPeers(managers) await waitForPeers([a, c]) ``` I think this is a useful change on its own, but will also make [an upcoming change][0] easier. [0]: #865
EvanHahn
added a commit
that referenced
this pull request
Sep 25, 2024
`waitForPeers`, a test helper, currently checks that the *number* of connected peers is expected. This has two problems: - If the number of connected peers is *more than needed*, it will never resolve. - If the *number* of connected peers is correct but the actual peers are different, the promise could resolve prematurely. This snippet highlights the problem: ```javascript const managers = await createManagers(3, t) const [a, b, c] = managers connectPeers(managers) await waitForPeers([a, c]) ``` I think this is a useful change on its own, but will also make [an upcoming change][0] easier. [0]: #865
EvanHahn
force-pushed
the
invite-should-wait-for-peers
branch
2 times, most recently
from
5f0dff7 to
c07a8a8
Compare
Our `invite` helper breaks if other peers aren't found. There's no time we'd use `invite` without waiting for other peers to be found, so let's always wait for them in `invite`.
EvanHahn
force-pushed
the
invite-should-wait-for-peers
branch
from
c07a8a8 to
051085a
Compare
tomasciccola
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend reviewing this with whitespace changes disabled.
Our
invitehelper breaks if other peers aren't found. There's no time we'd useinvitewithout waiting for other peers to be found, so let's always wait for them ininvite.