chore: test re-loading manager with the same data #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test-only change creates a project. Then, it makes a new manager with the same files and asserts that the project is still there. Because the only way to close a manager is to close the Node process, this test adds a bunch of scaffolding to do that.
| ` | ||
|
|
||
| const result = temporaryFile({ extension: 'mjs' }) | ||
| this.#t.teardown(() => fsPromises.rm(result, { maxRetries: 2 })) |
There was a problem hiding this comment.
only nit, why is there two calls to t.teardown (one here, and one in the constructor)?
There was a problem hiding this comment.
dbFolder and coreStorage are created once per ManagerCustodian. These JS files are created once per call to withManagerInSeparateProcess.
In my test, for example, dbFolder is created once (and therefore needs to be removed once) and the JS file is created twice (and therefore needs to be removed twice).
Does that answer your question?
tomasciccola
approved these changes
Apr 24, 2024
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test-only change creates a project. Then, it makes a new manager with the same files and asserts that the project is still there.
Because the only way to close a manager is to close the Node process, this test adds a bunch of scaffolding to do that.