feat: add "received at" timestamp to invites #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it possible for the frontend to sort incoming invites.
EvanHahn
commented
Mar 27, 2024
| @@ -90,7 +98,7 @@ | |||
| "eslint": "^8.57.0", | |||
| "filter-obj": "^6.0.0", | |||
| "husky": "^8.0.0", | |||
| "iterpal": "^0.3.0", | |||
| "iterpal": "^0.4.0", | |||
There was a problem hiding this comment.
Necessary to pull in compact for tests.
| "error", | ||
| { | ||
| "varsIgnorePattern": "^_", | ||
| "argsIgnorePattern": "^_" |
There was a problem hiding this comment.
I use varsIgnorePattern in this PR, but not argsIgnorePattern. I added it for consistency.
gmaclennan
approved these changes
Mar 27, 2024
tests/invite-api.js
Outdated
| @@ -1047,3 +1099,73 @@ function setup() { | |||
| encryptionKeys, | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Assert that invites are alike, allowing for some wiggle room around | |||
There was a problem hiding this comment.
can you add a note about what wiggle room means here, to help a future maintainer who might find this failing.
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it possible for the frontend to sort incoming invites, and was requested by Erik.