chore: update config import error #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a problem where the config import tests failed. This seemed to be
because the `JSON.parse()` error message can change.
For example, `JSON.parse('{bad')` gives the following error message in
Firefox v123:
> expected property name or '}' at line 1 column 2 of the JSON data
But Node v20 gives the following:
> Expected property name or '}' in JSON at position 1
We now catch this error and return a consistent message, which should
make the tests more reliable. Because this code was getting a little
long, I moved it into its own function.
This was referenced Apr 11, 2024
This was referenced Jun 20, 2024
This was referenced Jul 25, 2024
This was referenced Aug 21, 2024
This was referenced Aug 29, 2024
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a problem where the config import tests failed. This seemed to be because the
JSON.parse()error message can change.For example,
JSON.parse('{bad')gives the following error message in Firefox v123:But Node v20 gives the following:
We now catch this error and return a consistent message, which should make the tests more reliable. Because this code was getting a little long, I moved it into its own function.