Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable useUnknownInCatchVariables TypeScript option #494

Merged
merged 6 commits into from
Feb 22, 2024
Merged

chore: enable useUnknownInCatchVariables TypeScript option #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
99a46d0
chore: enable useUnknownInCatchVariables TypeScript option
EvanHahn Feb 21, 2024
e8ac42d
`instanceof Error` instead of `isRecord`
EvanHahn Feb 22, 2024
24284a1
Remove unused import
EvanHahn Feb 22, 2024
f82f995
Merge branch 'main' into useUnknownInCatchVariables
EvanHahn Feb 22, 2024
3febedc
Remove errify
EvanHahn Feb 22, 2024
aaf0af5
Move isRecord back into the one place it is used
EvanHahn Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/blob-store/live-download.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ export class DriveLiveDownload extends TypedEmitter {
const [blobs] = await once(this.#drive, 'blobs', { signal: this.#signal })
return blobs.core
} catch (e) {
if (e.name === 'AbortError') return
if (e instanceof Error && e.name === 'AbortError') return
throw e
}
}
Expand Down
6 changes: 5 additions & 1 deletion src/config-import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,11 @@ export async function readConfig(configPath) {
}
}
} catch (err) {
warnings.push(err)
warnings.push(
err instanceof Error
? err
: new Error('Unknown error importing icon')
)
}
}
if (icon) {
Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"strictNullChecks": true,
"strictBindCallApply": true,
"strictPropertyInitialization": true,
"useUnknownInCatchVariables": true,
"allowSyntheticDefaultImports": true,
"resolveJsonModule": true,
"module": "Node16",
Expand Down
Loading