Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update @mapeo/schema to get new features #477

Merged
merged 6 commits into from
Feb 21, 2024
Merged

Conversation

EvanHahn
Copy link
Contributor

This updates @mapeo/schema to 3.0.0-next.14, which pulls in two significant features:

  1. New Translation schema
  2. New deviceType property on DeviceInfo

Neither of these are useful right now but will unblock upcoming changes.

This updates `@mapeo/schema` to `3.0.0-next.14`, which pulls in two
significant features:

1. New `Translation` schema
2. New `deviceType` property on `DeviceInfo`

Neither of these are useful right now but will unblock upcoming changes.
@EvanHahn EvanHahn force-pushed the update-mapeo-schema branch from 0a0bc31 to 80cd99d Compare February 14, 2024 15:58
@EvanHahn EvanHahn marked this pull request as ready for review February 14, 2024 16:08
@EvanHahn EvanHahn self-assigned this Feb 14, 2024
Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The drizzle changes currently reflect a proper migration, but in this case we should just override the existing schema files

drizzle/project/meta/_journal.json Outdated Show resolved Hide resolved
@EvanHahn
Copy link
Contributor Author

The drizzle changes currently reflect a proper migration, but in this case we should just override the existing schema files

Done in fdbdcd3.

@EvanHahn EvanHahn requested a review from achou11 February 15, 2024 02:56
Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another note about deps pinning

package.json Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@EvanHahn EvanHahn requested a review from achou11 February 15, 2024 20:10
@EvanHahn EvanHahn removed their assignment Feb 20, 2024
Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for not getting to this sooner - thought i had already approved it!

@EvanHahn EvanHahn merged commit 5e05e35 into main Feb 21, 2024
7 checks passed
@EvanHahn EvanHahn deleted the update-mapeo-schema branch February 21, 2024 21:54
@EvanHahn
Copy link
Contributor Author

No worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants