Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: share deviceType with local peers #461

Merged
merged 3 commits into from
Feb 8, 2024
Merged

feat: share deviceType with local peers #461

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b57be00
feat: share deviceType with local peers
gmaclennan Jan 31, 2024
70dc247
Incorporate review comments
gmaclennan Feb 5, 2024
80d1f2c
fix bug in teardown
gmaclennan Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions proto/rpc.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,11 @@ message InviteResponse {
}

message DeviceInfo {
enum DeviceType {
gmaclennan marked this conversation as resolved.
Show resolved Hide resolved
mobile = 0;
tablet = 1;
desktop = 2;
}
string name = 1;
optional DeviceType deviceType = 2;
}
18 changes: 16 additions & 2 deletions src/generated/rpc.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,17 @@ export declare function inviteResponse_DecisionFromJSON(object: any): InviteResp
export declare function inviteResponse_DecisionToNumber(object: InviteResponse_Decision): number;
export interface DeviceInfo {
name: string;
deviceType?: DeviceInfo_DeviceType | undefined;
}
export declare const DeviceInfo_DeviceType: {
readonly mobile: "mobile";
readonly tablet: "tablet";
readonly desktop: "desktop";
readonly UNRECOGNIZED: "UNRECOGNIZED";
};
export type DeviceInfo_DeviceType = typeof DeviceInfo_DeviceType[keyof typeof DeviceInfo_DeviceType];
export declare function deviceInfo_DeviceTypeFromJSON(object: any): DeviceInfo_DeviceType;
export declare function deviceInfo_DeviceTypeToNumber(object: DeviceInfo_DeviceType): number;
export declare const Invite: {
encode(message: Invite, writer?: _m0.Writer): _m0.Writer;
decode(input: _m0.Reader | Uint8Array, length?: number): Invite;
Expand Down Expand Up @@ -148,12 +158,16 @@ export declare const DeviceInfo: {
decode(input: _m0.Reader | Uint8Array, length?: number): DeviceInfo;
create<I extends {
name?: string;
deviceType?: DeviceInfo_DeviceType | undefined;
} & {
name?: string;
} & { [K in Exclude<keyof I, "name">]: never; }>(base?: I): DeviceInfo;
deviceType?: DeviceInfo_DeviceType | undefined;
} & { [K in Exclude<keyof I, keyof DeviceInfo>]: never; }>(base?: I): DeviceInfo;
fromPartial<I_1 extends {
name?: string;
deviceType?: DeviceInfo_DeviceType | undefined;
} & {
name?: string;
} & { [K_1 in Exclude<keyof I_1, "name">]: never; }>(object: I_1): DeviceInfo;
deviceType?: DeviceInfo_DeviceType | undefined;
} & { [K_1 in Exclude<keyof I_1, keyof DeviceInfo>]: never; }>(object: I_1): DeviceInfo;
};
Loading
Loading