Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: exclude deleted from getMany(), option to include #460

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

gmaclennan
Copy link
Member

BREAKING CHANGE: default to exclude deleted records from getMany(),
and add an option includeDeleted. Fixes #295

BREAKING CHANGE: default to exclude deleted records from getMany(),
and add an option `includeDeleted`. Fixes #295
@gmaclennan gmaclennan self-assigned this Jan 31, 2024
@gmaclennan gmaclennan requested a review from EvanHahn January 31, 2024 10:48
Copy link
Contributor

@EvanHahn EvanHahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to ignore my comment.

test-e2e/project-crud.js Outdated Show resolved Hide resolved
@gmaclennan gmaclennan merged commit 5ff5022 into main Feb 7, 2024
7 checks passed
@gmaclennan gmaclennan deleted the feat/get-many-exclude-deleted branch February 7, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datatype.getMany() should have includeDeleted: false as default
2 participants