Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update cores sqlite table when deleting data using CoreManager #429

Merged
merged 6 commits into from
Jan 11, 2024
Merged

fix: update cores sqlite table when deleting data using CoreManager #429

merged 6 commits into from
Jan 11, 2024

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Jan 10, 2024

Fixes #428

Applies the following changes:

  • Ports cores table to use Drizzle interface
  • Updates CoreManager.deleteData() to update the cores table
  • Minor - and mostly preventative - fixes to test setup related to changes around the CoreManager

@achou11 achou11 requested a review from gmaclennan January 10, 2024 20:54
achou11
achou11 commented Jan 10, 2024
View reviewed changes
src/core-manager/index.js Outdated Show resolved Hide resolved
src/core-manager/index.js Show resolved Hide resolved
src/core-manager/index.js Show resolved Hide resolved
gmaclennan
gmaclennan approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of non-blocking suggestions.

src/core-manager/index.js Show resolved Hide resolved
src/core-manager/index.js Outdated Show resolved Hide resolved
tests/core-manager.js Show resolved Hide resolved
@achou11 achou11 merged commit 8dee5f0 into main Jan 11, 2024
7 checks passed
@achou11 achou11 deleted the 428/update-cores-table branch January 11, 2024 14:58
@optic-release-automation optic-release-automation bot mentioned this pull request Mar 14, 2024
Merged
This was referenced Apr 11, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Apr 30, 2024
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request May 9, 2024
Merged
This was referenced Jun 20, 2024
Merged
Merged
Merged
This was referenced Jul 25, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Aug 13, 2024
Merged
This was referenced Aug 21, 2024
Merged
Merged
This was referenced Aug 29, 2024
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 11, 2024
Closed
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmaclennan gmaclennan gmaclennan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete data in cores table when calling CoreManager.deleteData()
2 participants
@achou11 @gmaclennan