Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: delete() by docId not versionId(s) #424

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

gmaclennan
Copy link
Member

Fixes "dataType.delete() should use docId not versionId" (#422)

The deletion document links to all forks, if forks exist.

Fixes "`dataType.delete()` should use `docId` not `versionId`" (#422)

The deletion document links to all forks, if forks exist.
@gmaclennan gmaclennan linked an issue Dec 19, 2023 that may be closed by this pull request
@gmaclennan gmaclennan self-assigned this Dec 19, 2023
@gmaclennan gmaclennan requested a review from achou11 December 19, 2023 13:50
src/datatype/index.js Outdated Show resolved Hide resolved
@gmaclennan gmaclennan merged commit cf1910f into main Dec 19, 2023
7 checks passed
@gmaclennan gmaclennan deleted the fix/delete-by-doc-id branch December 19, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: dataType.delete() should use docId not versionId
2 participants