Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grab existing doc when calling dataType.delete, test it #420

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

tomasciccola
Copy link
Contributor

No description provided.

Copy link
Member

@achou11 achou11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion for improving the test

tests/data-type.js Outdated Show resolved Hide resolved
@tomasciccola tomasciccola requested a review from achou11 December 14, 2023 15:55
tests/data-type.js Outdated Show resolved Hide resolved
tests/data-type.js Outdated Show resolved Hide resolved
Co-authored-by: Andrew Chou <andrewchou@fastmail.com>
@tomasciccola tomasciccola requested a review from achou11 December 14, 2023 16:04
@tomasciccola tomasciccola merged commit aee15c2 into main Dec 14, 2023
7 checks passed
@tomasciccola tomasciccola deleted the fix/passDocToDelete branch December 14, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants