Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix core storage initialization in MapeoManager #367

Merged
merged 2 commits into from
Nov 9, 2023
Merged

fix: fix core storage initialization in MapeoManager #367

merged 2 commits into from
Nov 9, 2023

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Nov 8, 2023

Seems like the createStorage() is not a static method on Hypercore for the version we're using. Can't find any record of that ever existing, and my assumption is that we want to use Hypercore.defaultStorage() instead

https://github.com/holepunchto/hypercore/blob/v10.17.0/index.js#L176

ideally should update @digidem/types too

@achou11 achou11 requested a review from gmaclennan November 8, 2023 22:14
@achou11 achou11 mentioned this pull request Nov 8, 2023
Closed
@gmaclennan
Copy link
Member

My apologies, I had noticed this and fixed in one of my sync PRs, but had not merged until now. The switch to @ts-expect-error makes sense.

@gmaclennan gmaclennan merged commit 75ea34a into main Nov 9, 2023
7 checks passed
@gmaclennan gmaclennan deleted the ac/hypercore-default-storage branch November 9, 2023 07:32
gmaclennan added a commit that referenced this pull request Nov 9, 2023
@gmaclennan
Merge branch 'main' into feat/IconHttpServer
cc76864 
* main:
  fix: fix core storage initialization in MapeoManager (#367)
  feat: add `$sync` API methods (#361)
  feat: `listLocalPeers()` & `local-peers` event (#360)
  feat: integrate LocalDiscovery & LocalPeers (#358)
gmaclennan added a commit that referenced this pull request Nov 10, 2023
@gmaclennan
Merge branch 'main' into feat/initial-download
f58bbaf 
* main:
  implement media server (#365)
  feat: implement icon server plugin (#315)
  fix: fix core storage initialization in MapeoManager (#367)
This was referenced Nov 16, 2023
Closed
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Dec 4, 2023
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Dec 12, 2023
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Mar 14, 2024
Merged
This was referenced Apr 11, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Apr 30, 2024
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request May 9, 2024
Merged
This was referenced Jun 20, 2024
Merged
Merged
Merged
This was referenced Jul 25, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Aug 13, 2024
Merged
This was referenced Aug 21, 2024
Merged
Merged
This was referenced Aug 29, 2024
Merged
Merged
Merged
This was referenced Sep 2, 2024
Merged
Merged
Merged
This was referenced Sep 11, 2024
Closed
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmaclennan gmaclennan gmaclennan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achou11 @gmaclennan